Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2288593003: Use stream printers in showNodePath() and Node::showTreeForThisAcrossFrame() implementations. (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use stream printers in showNodePath() and Node::showTreeForThisAcrossFrame() implementations. This is a preparation to remove WTFLogAlways() from Node.cpp. This CL renames the followings: - Node::showNodePathForThis() to printNodePathTo() - showSubTreeAcrossFrame() to printSubTreeAcrossFrame() because they don't *show* anything to the console any longer. This CL has no behavior changes. BUG=638849 Committed: https://crrev.com/dea7e1c68164dd101f0c44bd0608379961774edd Cr-Commit-Position: refs/heads/master@{#414991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 7 chunks +26 lines, -20 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
tkent
yosin@, would you review this please?
4 years, 3 months ago (2016-08-29 05:06:43 UTC) #10
yosin_UTC9
lgtm
4 years, 3 months ago (2016-08-29 06:46:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288593003/20001
4 years, 3 months ago (2016-08-29 06:46:25 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-08-29 10:14:50 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 10:16:35 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dea7e1c68164dd101f0c44bd0608379961774edd
Cr-Commit-Position: refs/heads/master@{#414991}

Powered by Google App Engine
This is Rietveld 408576698