Issue 2288593002: DevTools: Use a Map for modelListeners in TargetManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2288593002: DevTools: Use a Map for modelListeners in TargetManager (Closed)

Created:
4 years, 3 months ago by alph

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2840

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

DevTools: Use a Map for modelListeners in TargetManager The Object used to store the listeners before does not support iteration over Symbol keys. BUG=641468 Review-Url: https://codereview.chromium.org/2284663003 Cr-Commit-Position: refs/heads/master@{#414816} (cherry picked from commit 895cd721262c4fcf86ea35e5a3fdb92bb8b85fdd) Committed: https://chromium.googlesource.com/chromium/src/+/b78c8f740d3059bc3d837ef23196af8fa5a2ac58

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js	View		6 chunks	+16 lines, -16 lines	0 comments	Download

Total messages: 2 (1 generated)

alph

4 years, 3 months ago (2016-08-28 22:04:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b78c8f740d3059bc3d837ef23196af8fa5a2ac58.