Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2288593002: DevTools: Use a Map for modelListeners in TargetManager (Closed)

Created:
4 years, 3 months ago by alph
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2840
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

DevTools: Use a Map for modelListeners in TargetManager The Object used to store the listeners before does not support iteration over Symbol keys. BUG=641468 Review-Url: https://codereview.chromium.org/2284663003 Cr-Commit-Position: refs/heads/master@{#414816} (cherry picked from commit 895cd721262c4fcf86ea35e5a3fdb92bb8b85fdd) Committed: https://chromium.googlesource.com/chromium/src/+/b78c8f740d3059bc3d837ef23196af8fa5a2ac58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 6 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
alph
4 years, 3 months ago (2016-08-28 22:04:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b78c8f740d3059bc3d837ef23196af8fa5a2ac58.

Powered by Google App Engine
This is Rietveld 408576698