Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2288583002: Reorder the AnimatedPropertyType enumeration (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp
index 26e0d38ddc0333ac465aafe22444790a08bb8121..f0748a37561b247338dae7c88cff870c369e0c19 100644
--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp
@@ -703,11 +703,9 @@ AnimatedPropertyType SVGElement::animatedPropertyTypeForCSSAttribute(const Quali
for (size_t i = 0; i < WTF_ARRAY_LENGTH(attrToTypes); i++)
cssPropertyMap.set(attrToTypes[i].attr, attrToTypes[i].propType);
}
-
- if (cssPropertyMap.contains(attributeName))
- return cssPropertyMap.get(attributeName);
-
- return AnimatedUnknown;
+ // If the attribute is not present in the map, this will return the "empty
+ // value" per HashTraits - which is AnimatedUnknown.
+ return cssPropertyMap.get(attributeName);
pdr. 2016/08/29 00:07:09 In addition to this comment, can you enforce it wi
}
void SVGElement::addToPropertyMap(SVGAnimatedPropertyBase* property)

Powered by Google App Engine
This is Rietveld 408576698