Reorder the AnimatedPropertyType enumeration

Reorder the AnimatedPropertyType enumeration

By moving AnimatedUnknown first (giving it the ordinal value 0), we can
simplify SVGElement::animatedPropertyTypeForCSSAttribute by removing
the contains() call (avoiding a double hash/lookup for the common case.)

Committed: https://crrev.com/313fea79b7a2735852ab6920532fae49ad8d5b60
Cr-Commit-Position: refs/heads/master@{#415069}

[fs, 2016-08-28 21:35:00]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-28 21:35:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-08-28 22:27:15]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[commit-bot: I haz the power, 2016-08-28 22:44:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-28 22:44:58]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pdr., 2016-08-29 00:07:09]

LGTM with two optional suggestions.

https://codereview.chromium.org/2288583002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGElement.cpp (right):

https://codereview.chromium.org/2288583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGElement.cpp:708: return
cssPropertyMap.get(attributeName);
In addition to this comment, can you enforce it with a DCHECK to prevent against
bad refactorings of the enum or hashtraits?

Possibly the following here or up in the cssPropertyMap initialization block
above:
DCHECK(HashTraits<AnimatedPropertyType>::emptyValue() == AnimatedUnknown);

https://codereview.chromium.org/2288583002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/properties/SVGPropertyInfo.h (right):

https://codereview.chromium.org/2288583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/properties/SVGPropertyInfo.h:26:
AnimatedUnknown,
WDYT about making this 0 explicit?

e.g.,:
enum AnimatedPropertyType {
    AnimatedUnknown = 0,
    AnimatedAngle,
    AnimatedBoolean,
    ...
};

[fs, 2016-08-29 09:03:28]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 09:03:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-08-29 09:04:09]

On 2016/08/29 at 00:07:09, pdr wrote:
> LGTM with two optional suggestions.

Both good suggestions. Implemented.

[commit-bot: I haz the power, 2016-08-29 10:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 10:19:04]

Dry run: Exceeded global retry quota

[fs, 2016-08-29 19:15:14]

The CQ bit was checked by fs@opera.com

[fs, 2016-08-29 19:15:15]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2288583002/#ps20001
(title: "Touch-ups")

[commit-bot: I haz the power, 2016-08-29 19:54:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 04:03:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 04:06:54]

Description was changed from

==========
Reorder the AnimatedPropertyType enumeration

By moving AnimatedUnknown first (giving it the ordinal value 0), we can
simplify SVGElement::animatedPropertyTypeForCSSAttribute by removing
the contains() call (avoiding a double hash/lookup for the common case.)
==========

to

==========
Reorder the AnimatedPropertyType enumeration

By moving AnimatedUnknown first (giving it the ordinal value 0), we can
simplify SVGElement::animatedPropertyTypeForCSSAttribute by removing
the contains() call (avoiding a double hash/lookup for the common case.)

Committed: https://crrev.com/313fea79b7a2735852ab6920532fae49ad8d5b60
Cr-Commit-Position: refs/heads/master@{#415069}
==========

[commit-bot: I haz the power, 2016-08-30 04:06:55]

Patchset 2 (id:??) landed as
https://crrev.com/313fea79b7a2735852ab6920532fae49ad8d5b60
Cr-Commit-Position: refs/heads/master@{#415069}