Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2288523002: Remove most of src/cc functions from the CFI blacklist. (Closed)

Created:
4 years, 3 months ago by krasin
Modified:
4 years, 3 months ago
Reviewers:
krasin1, kcc2
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove most of src/cc functions from the CFI blacklist. They are now excluded from CFI checks with DISABLE_CFI_PERF attributes, see https://codereview.chromium.org/2257323002/ BUG=641536 TBR=kcc@chromium.org Committed: https://crrev.com/13f28a78f183528e9ba1747f02e4b012849f8dd9 Cr-Commit-Position: refs/heads/master@{#414947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M tools/cfi/blacklist.txt View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288523002/1
4 years, 3 months ago (2016-08-27 21:31:13 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-08-27 21:31:15 UTC) #4
krasin1
self LGTM
4 years, 3 months ago (2016-08-27 23:03:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288523002/1
4 years, 3 months ago (2016-08-27 23:04:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-27 23:45:37 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13f28a78f183528e9ba1747f02e4b012849f8dd9 Cr-Commit-Position: refs/heads/master@{#414947}
4 years, 3 months ago (2016-08-27 23:47:09 UTC) #10
kcc2
4 years, 3 months ago (2016-08-29 18:06:30 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698