tools/json_schema_compiler/cc_generator.py - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cc_generator.py

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/json_schema_compiler/cc_generator.py

diff --git a/tools/json_schema_compiler/cc_generator.py b/tools/json_schema_compiler/cc_generator.py

index 8a844cf8013feb348863cda595d0d68cfa43cc5c..67a16e2302ee6cadd9cfeea43d9bc5334110157b 100644

--- a/tools/json_schema_compiler/cc_generator.py

+++ b/tools/json_schema_compiler/cc_generator.py

@@ -435,7 +435,7 @@ class _Generator(object):

var: variable or variable*

- E.g for std::string, generate base::Value::CreateStringValue(var)

+ E.g for std::string, generate new base::StringValue(var)

"""

underlying_type = self._type_helper.FollowRef(type_)

if (underlying_type.property_type == PropertyType.CHOICES or

@@ -452,7 +452,7 @@ class _Generator(object):

vardot = '(%s).' % var

return '%sDeepCopy()' % vardot

elif underlying_type.property_type == PropertyType.ENUM:

- return 'base::Value::CreateStringValue(ToString(%s))' % var

+ return 'new base::StringValue(ToString(%s))' % var

elif underlying_type.property_type == PropertyType.BINARY:

if is_ptr:

vardot = var + '->'

« no previous file with comments | « chrome/browser/extensions/menu_manager_unittest.cc ('k') | tools/json_schema_compiler/util.cc » ('j') | no next file with comments »