chrome/browser/extensions/api/usb/usb_api.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/usb/usb_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/test/test_api.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/usb/usb_api.cc

diff --git a/chrome/browser/extensions/api/usb/usb_api.cc b/chrome/browser/extensions/api/usb/usb_api.cc

index 878e3625dd45655fd6e019ddaa846e11110f5c23..6fa3aa264a68748ebd3037fae45410b65981ad3b 100644

--- a/chrome/browser/extensions/api/usb/usb_api.cc

+++ b/chrome/browser/extensions/api/usb/usb_api.cc

@@ -65,7 +65,7 @@ static const char kErrorCannotClaimInterface[] = "Error claiming interface.";

static const char kErrorCannotReleaseInterface[] = "Error releasing interface.";

static const char kErrorCannotSetInterfaceAlternateSetting[] =

"Error setting alternate interface setting.";

-static const char kErrorConvertDirection[] = "Invalid transfer direction.";

+static const char kErrorConvertDirection[] = "Invalid transsfer direction.";

static const char kErrorConvertRecipient[] = "Invalid transfer recipient.";

static const char kErrorConvertRequestType[] = "Invalid request type.";

static const char kErrorConvertSynchronizationType[] =

@@ -1041,14 +1041,14 @@ void UsbResetDeviceFunction::OnCompleted(bool success) {

base::Bind(&UsbResetDeviceFunction::OnError, this));

return;

}

- SetResult(Value::CreateBooleanValue(true));

+ SetResult(new base::FundamentalValue(true));

AsyncWorkCompleted();

}

void UsbResetDeviceFunction::OnError() {

RemoveUsbDeviceResource(parameters_->device.handle);

SetError(kErrorResetDevice);

- SetResult(Value::CreateBooleanValue(false));

+ SetResult(new base::FundamentalValue(false));

AsyncWorkCompleted();

}