Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
diff --git a/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc b/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
index f318596f908765d2792e85a6498251059e1f589b..a400971520a64d37194ecbce699e08c3306accdf 100644
--- a/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
+++ b/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
@@ -99,12 +99,12 @@ void SyncFileSystemDeleteFileSystemFunction::DidDeleteFileSystem(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
if (error != base::PLATFORM_FILE_OK) {
error_ = base::StringPrintf(kFileError, static_cast<int>(error));
- SetResult(base::Value::CreateBooleanValue(false));
+ SetResult(new base::FundamentalValue(false));
SendResponse(false);
return;
}
- SetResult(base::Value::CreateBooleanValue(true));
+ SetResult(new base::FundamentalValue(true));
SendResponse(true);
}
@@ -380,7 +380,7 @@ bool SyncFileSystemGetConflictResolutionPolicyFunction::RunImpl() {
api::sync_file_system::ConflictResolutionPolicy policy =
ConflictResolutionPolicyToExtensionEnum(
service->GetConflictResolutionPolicy());
- SetResult(Value::CreateStringValue(
+ SetResult(new base::StringValue(
api::sync_file_system::ToString(policy)));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698