Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: chrome/browser/extensions/api/serial/serial_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/serial/serial_api.cc
diff --git a/chrome/browser/extensions/api/serial/serial_api.cc b/chrome/browser/extensions/api/serial/serial_api.cc
index b0e7925c9eb4ce9314507dfefbefa0e3c4363f54..b9589440c38d26ac9ed78a296f873e8138f0cd1a 100644
--- a/chrome/browser/extensions/api/serial/serial_api.cc
+++ b/chrome/browser/extensions/api/serial/serial_api.cc
@@ -65,7 +65,7 @@ void SerialGetPortsFunction::Work() {
SerialPortEnumerator::GenerateValidSerialPortNames();
SerialPortEnumerator::StringSet::const_iterator i = port_names.begin();
while (i != port_names.end()) {
- ports->Append(Value::CreateStringValue(*i++));
+ ports->Append(new base::StringValue(*i++));
}
SetResult(ports);
@@ -182,7 +182,7 @@ void SerialCloseFunction::Work() {
close_result = true;
}
- SetResult(Value::CreateBooleanValue(close_result));
+ SetResult(new base::FundamentalValue(close_result));
}
bool SerialCloseFunction::Respond() {
@@ -294,7 +294,7 @@ void SerialFlushFunction::Work() {
flush_result = true;
}
- SetResult(Value::CreateBooleanValue(flush_result));
+ SetResult(new base::FundamentalValue(flush_result));
}
bool SerialFlushFunction::Respond() {
@@ -369,14 +369,14 @@ void SerialSetControlSignalsFunction::Work() {
if (control_signals.should_set_rts)
control_signals.rts = *(params_->options.rts);
if (serial_connection->SetControlSignals(control_signals)) {
- SetResult(Value::CreateBooleanValue(true));
+ SetResult(new base::FundamentalValue(true));
} else {
error_ = kErrorSetControlSignalsFailed;
- SetResult(Value::CreateBooleanValue(false));
+ SetResult(new base::FundamentalValue(false));
}
} else {
error_ = kSerialConnectionNotFoundError;
- SetResult(Value::CreateBooleanValue(false));
+ SetResult(new base::FundamentalValue(false));
}
}
« no previous file with comments | « chrome/browser/extensions/api/runtime/runtime_api.cc ('k') | chrome/browser/extensions/api/socket/socket_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698