Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3374)

Unified Diff: chrome/browser/extensions/api/module/module.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/module/module.cc
diff --git a/chrome/browser/extensions/api/module/module.cc b/chrome/browser/extensions/api/module/module.cc
index d9c11b77b45edcf1bb9fdd9b3abf1cdc6ce860e1..b1295d1650a0d2296af0829ffa56e101c89cf0ef 100644
--- a/chrome/browser/extensions/api/module/module.cc
+++ b/chrome/browser/extensions/api/module/module.cc
@@ -41,7 +41,7 @@ bool ExtensionSetUpdateUrlDataFunction::RunImpl() {
ExtensionPrefs::Get(profile())->UpdateExtensionPref(
extension_id(),
extension::kUpdateURLData,
- base::Value::CreateStringValue(data));
+ new base::StringValue(data));
return true;
}
@@ -50,7 +50,7 @@ bool ExtensionIsAllowedIncognitoAccessFunction::RunImpl() {
ExtensionSystem::Get(profile())->extension_service();
const Extension* extension = GetExtension();
- SetResult(Value::CreateBooleanValue(
+ SetResult(new base::FundamentalValue(
ext_service->IsIncognitoEnabled(extension->id())));
return true;
}
@@ -60,7 +60,7 @@ bool ExtensionIsAllowedFileSchemeAccessFunction::RunImpl() {
ExtensionSystem::Get(profile())->extension_service();
const Extension* extension = GetExtension();
- SetResult(Value::CreateBooleanValue(
+ SetResult(new base::FundamentalValue(
ext_service->AllowFileAccess(extension)));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698