Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc
diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
index a4c5a2c225c5e3da8dbb13f67e54a7ba21ca0289..e528f9b5c4606a91edd5a12673daa855384e9bbb 100644
--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc
+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
@@ -253,7 +253,7 @@ void ExtensionActionAPI::SetBrowserActionVisibility(
prefs->UpdateExtensionPref(extension_id,
kBrowserActionVisible,
- Value::CreateBooleanValue(visible));
+ new base::FundamentalValue(visible));
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,
content::Source<ExtensionPrefs>(prefs),
@@ -655,28 +655,32 @@ bool ExtensionActionSetBadgeBackgroundColorFunction::RunExtensionAction() {
}
bool ExtensionActionGetTitleFunction::RunExtensionAction() {
- SetResult(Value::CreateStringValue(extension_action_->GetTitle(tab_id_)));
+ SetResult(new base::StringValue(extension_action_->GetTitle(tab_id_)));
return true;
}
bool ExtensionActionGetPopupFunction::RunExtensionAction() {
SetResult(
- Value::CreateStringValue(extension_action_->GetPopupUrl(tab_id_).spec()));
+ new base::StringValue(extension_action_->GetPopupUrl(tab_id_).spec()));
return true;
}
bool ExtensionActionGetBadgeTextFunction::RunExtensionAction() {
- SetResult(Value::CreateStringValue(extension_action_->GetBadgeText(tab_id_)));
+ SetResult(new base::StringValue(extension_action_->GetBadgeText(tab_id_)));
return true;
}
bool ExtensionActionGetBadgeBackgroundColorFunction::RunExtensionAction() {
base::ListValue* list = new base::ListValue();
SkColor color = extension_action_->GetBadgeBackgroundColor(tab_id_);
- list->Append(Value::CreateIntegerValue(SkColorGetR(color)));
- list->Append(Value::CreateIntegerValue(SkColorGetG(color)));
- list->Append(Value::CreateIntegerValue(SkColorGetB(color)));
- list->Append(Value::CreateIntegerValue(SkColorGetA(color)));
+ list->Append(
+ new base::FundamentalValue(static_cast<int>(SkColorGetR(color))));
+ list->Append(
+ new base::FundamentalValue(static_cast<int>(SkColorGetG(color))));
+ list->Append(
+ new base::FundamentalValue(static_cast<int>(SkColorGetB(color))));
+ list->Append(
+ new base::FundamentalValue(static_cast<int>(SkColorGetA(color))));
SetResult(list);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698