Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_window/app_window_api.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc
index 7fa2492073dcaf3a8729ea0f2714c0ebcb7c0e67..97b52f2b2e2221b7df9c23b31471602c44246561 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc
@@ -164,7 +164,7 @@ bool AppWindowCreateFunction::RunImpl() {
window->GetBaseWindow()->Show();
base::DictionaryValue* result = new base::DictionaryValue;
- result->Set("viewId", base::Value::CreateIntegerValue(view_id));
+ result->Set("viewId", new base::FundamentalValue(view_id));
SetCreateResultFromShellWindow(window, result);
result->SetBoolean("existingWindow", true);
result->SetBoolean("injectTitlebar", false);
@@ -311,10 +311,10 @@ bool AppWindowCreateFunction::RunImpl() {
view_id = created_view->GetRoutingID();
base::DictionaryValue* result = new base::DictionaryValue;
- result->Set("viewId", base::Value::CreateIntegerValue(view_id));
+ result->Set("viewId", new base::FundamentalValue(view_id));
result->Set("injectTitlebar",
- base::Value::CreateBooleanValue(inject_html_titlebar));
- result->Set("id", base::Value::CreateStringValue(shell_window->window_key()));
+ new base::FundamentalValue(inject_html_titlebar));
+ result->Set("id", new base::StringValue(shell_window->window_key()));
SetCreateResultFromShellWindow(shell_window, result);
SetResult(result);
« no previous file with comments | « chrome/browser/extensions/admin_policy_unittest.cc ('k') | chrome/browser/extensions/api/bluetooth/bluetooth_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698