Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Side by Side Diff: tools/json_schema_compiler/util.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/json_schema_compiler/util.h" 5 #include "tools/json_schema_compiler/util.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 8
9 namespace json_schema_compiler { 9 namespace json_schema_compiler {
10 namespace util { 10 namespace util {
(...skipping 27 matching lines...) Expand all
38 bool GetItemFromList(const base::ListValue& from, int index, 38 bool GetItemFromList(const base::ListValue& from, int index,
39 linked_ptr<base::DictionaryValue>* out) { 39 linked_ptr<base::DictionaryValue>* out) {
40 const base::DictionaryValue* dict = NULL; 40 const base::DictionaryValue* dict = NULL;
41 if (!from.GetDictionary(index, &dict)) 41 if (!from.GetDictionary(index, &dict))
42 return false; 42 return false;
43 *out = make_linked_ptr(dict->DeepCopy()); 43 *out = make_linked_ptr(dict->DeepCopy());
44 return true; 44 return true;
45 } 45 }
46 46
47 void AddItemToList(const int from, base::ListValue* out) { 47 void AddItemToList(const int from, base::ListValue* out) {
48 out->Append(base::Value::CreateIntegerValue(from)); 48 out->Append(new base::FundamentalValue(from));
49 } 49 }
50 50
51 void AddItemToList(const bool from, base::ListValue* out) { 51 void AddItemToList(const bool from, base::ListValue* out) {
52 out->Append(base::Value::CreateBooleanValue(from)); 52 out->Append(new base::FundamentalValue(from));
53 } 53 }
54 54
55 void AddItemToList(const double from, base::ListValue* out) { 55 void AddItemToList(const double from, base::ListValue* out) {
56 out->Append(base::Value::CreateDoubleValue(from)); 56 out->Append(new base::FundamentalValue(from));
57 } 57 }
58 58
59 void AddItemToList(const std::string& from, base::ListValue* out) { 59 void AddItemToList(const std::string& from, base::ListValue* out) {
60 out->Append(base::Value::CreateStringValue(from)); 60 out->Append(new base::StringValue(from));
61 } 61 }
62 62
63 void AddItemToList(const linked_ptr<base::Value>& from, 63 void AddItemToList(const linked_ptr<base::Value>& from,
64 base::ListValue* out) { 64 base::ListValue* out) {
65 out->Append(from->DeepCopy()); 65 out->Append(from->DeepCopy());
66 } 66 }
67 67
68 void AddItemToList(const linked_ptr<base::DictionaryValue>& from, 68 void AddItemToList(const linked_ptr<base::DictionaryValue>& from,
69 base::ListValue* out) { 69 base::ListValue* out) {
70 out->Append(static_cast<base::Value*>(from->DeepCopy())); 70 out->Append(static_cast<base::Value*>(from->DeepCopy()));
71 } 71 }
72 72
73 } // namespace api_util 73 } // namespace api_util
74 } // namespace extensions 74 } // namespace extensions
OLDNEW
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698