Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_prefs_unittest.h" 5 #include "chrome/browser/extensions/extension_prefs_unittest.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/prefs/mock_pref_change_callback.h" 10 #include "base/prefs/mock_pref_change_callback.h"
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket); 162 PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
163 163
164 extension_id_ = prefs_.AddExtensionAndReturnId("test"); 164 extension_id_ = prefs_.AddExtensionAndReturnId("test");
165 165
166 api_perm_set1_.insert(APIPermission::kTab); 166 api_perm_set1_.insert(APIPermission::kTab);
167 api_perm_set1_.insert(APIPermission::kBookmark); 167 api_perm_set1_.insert(APIPermission::kBookmark);
168 scoped_ptr<APIPermission> permission( 168 scoped_ptr<APIPermission> permission(
169 permission_info->CreateAPIPermission()); 169 permission_info->CreateAPIPermission());
170 { 170 {
171 scoped_ptr<base::ListValue> value(new base::ListValue()); 171 scoped_ptr<base::ListValue> value(new base::ListValue());
172 value->Append(Value::CreateStringValue("tcp-connect:*.example.com:80")); 172 value->Append(new base::StringValue("tcp-connect:*.example.com:80"));
173 value->Append(Value::CreateStringValue("udp-bind::8080")); 173 value->Append(new base::StringValue("udp-bind::8080"));
174 value->Append(Value::CreateStringValue("udp-send-to::8888")); 174 value->Append(new base::StringValue("udp-send-to::8888"));
175 if (!permission->FromValue(value.get())) 175 if (!permission->FromValue(value.get()))
176 NOTREACHED(); 176 NOTREACHED();
177 } 177 }
178 api_perm_set1_.insert(permission.release()); 178 api_perm_set1_.insert(permission.release());
179 179
180 api_perm_set2_.insert(APIPermission::kHistory); 180 api_perm_set2_.insert(APIPermission::kHistory);
181 181
182 AddPattern(&ehost_perm_set1_, "http://*.google.com/*"); 182 AddPattern(&ehost_perm_set1_, "http://*.google.com/*");
183 AddPattern(&ehost_perm_set1_, "http://example.com/*"); 183 AddPattern(&ehost_perm_set1_, "http://example.com/*");
184 AddPattern(&ehost_perm_set1_, "chrome://favicon/*"); 184 AddPattern(&ehost_perm_set1_, "chrome://favicon/*");
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
756 756
757 private: 757 private:
758 scoped_refptr<const Extension> extension_a_; 758 scoped_refptr<const Extension> extension_a_;
759 scoped_refptr<const Extension> extension_b_; 759 scoped_refptr<const Extension> extension_b_;
760 scoped_refptr<const Extension> extension_c_; 760 scoped_refptr<const Extension> extension_c_;
761 }; 761 };
762 TEST_F(ExtensionPrefsBlacklistedExtensions, 762 TEST_F(ExtensionPrefsBlacklistedExtensions,
763 ExtensionPrefsBlacklistedExtensions) {} 763 ExtensionPrefsBlacklistedExtensions) {}
764 764
765 } // namespace extensions 765 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698