chrome/browser/extensions/api/dial/dial_api.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/dial/dial_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/discovery/discovery_api_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/api/dial/dial_api.h"	5 #include "chrome/browser/extensions/api/dial/dial_api.h"

6	6

7 #include <vector>	7 #include <vector>

8	8

9 #include "base/time/time.h"	9 #include "base/time/time.h"

10 #include "chrome/browser/extensions/api/dial/dial_api_factory.h"	10 #include "chrome/browser/extensions/api/dial/dial_api_factory.h"

(...skipping 149 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
160 void DialDiscoverNowFunction::Work() {	160 void DialDiscoverNowFunction::Work() {

161 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));	161 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

162 result_ = dial_->dial_registry()->DiscoverNow();	162 result_ = dial_->dial_registry()->DiscoverNow();

163 }	163 }

164	164

165 bool DialDiscoverNowFunction::Respond() {	165 bool DialDiscoverNowFunction::Respond() {

166 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));	166 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

167 if (!result_)	167 if (!result_)

168 error_ = kDialServiceError;	168 error_ = kDialServiceError;

169	169

170 SetResult(base::Value::CreateBooleanValue(result_));	170 SetResult(new base::FundamentalValue(result_));

171 return true;	171 return true;

172 }	172 }

173	173

174 } // namespace api	174 } // namespace api

175	175

176 } // namespace extensions	176 } // namespace extensions

OLD	NEW