c/b/extensions, json_schema_compiler: Do not use Value::Create*.

chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h"
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/message_loop/message_loop.h"
 #include "base/values.h"
@@ skipping 19 matching lines @@
 namespace keys = declarative_webrequest_constants;
 
 TEST(WebRequestConditionAttributeTest, CreateConditionAttribute) {
   // Necessary for TestURLRequest.
   base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
 
   std::string error;
   scoped_refptr<const WebRequestConditionAttribute> result;
   StringValue string_value("main_frame");
   ListValue resource_types;
-  resource_types.Append(Value::CreateStringValue("main_frame"));
+  resource_types.Append(new base::StringValue("main_frame"));
 
   // Test wrong condition name passed.
   error.clear();
   result = WebRequestConditionAttribute::Create(
       kUnknownConditionName, &resource_types, &error);
   EXPECT_FALSE(error.empty());
   EXPECT_FALSE(result.get());
 
   // Test wrong data type passed
   error.clear();
@@ skipping 20 matching lines @@
 }
 
 TEST(WebRequestConditionAttributeTest, ResourceType) {
   // Necessary for TestURLRequest.
   base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
 
   std::string error;
   ListValue resource_types;
   // The 'sub_frame' value is chosen arbitrarily, so as the corresponding
   // ResourceType::Type is not 0, the default value.
-  resource_types.Append(Value::CreateStringValue("sub_frame"));
+  resource_types.Append(new base::StringValue("sub_frame"));
 
   scoped_refptr<const WebRequestConditionAttribute> attribute =
       WebRequestConditionAttribute::Create(
           keys::kResourceTypeKey, &resource_types, &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(attribute.get());
   EXPECT_EQ(std::string(keys::kResourceTypeKey), attribute->GetName());
 
   net::TestURLRequestContext context;
   net::TestURLRequest url_request_ok(
@@ skipping 26 matching lines @@
   ASSERT_TRUE(test_server.Start());
 
   net::TestURLRequestContext context;
   net::TestDelegate delegate;
   net::TestURLRequest url_request(
       test_server.GetURL("files/headers.html"), &delegate, &context, NULL);
   url_request.Start();
   base::MessageLoop::current()->Run();
 
   ListValue content_types;
-  content_types.Append(Value::CreateStringValue("text/plain"));
+  content_types.Append(new base::StringValue("text/plain"));
   scoped_refptr<const WebRequestConditionAttribute> attribute_include =
       WebRequestConditionAttribute::Create(
           keys::kContentTypeKey, &content_types, &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(attribute_include.get());
   EXPECT_FALSE(attribute_include->IsFulfilled(
       WebRequestData(&url_request, ON_BEFORE_REQUEST,
                      url_request.response_headers())));
   EXPECT_TRUE(attribute_include->IsFulfilled(
       WebRequestData(&url_request, ON_HEADERS_RECEIVED,
                      url_request.response_headers())));
   EXPECT_EQ(std::string(keys::kContentTypeKey), attribute_include->GetName());
 
   scoped_refptr<const WebRequestConditionAttribute> attribute_exclude =
       WebRequestConditionAttribute::Create(
           keys::kExcludeContentTypeKey, &content_types, &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(attribute_exclude.get());
   EXPECT_FALSE(attribute_exclude->IsFulfilled(
       WebRequestData(&url_request, ON_HEADERS_RECEIVED,
                      url_request.response_headers())));
 
   content_types.Clear();
-  content_types.Append(Value::CreateStringValue("something/invalid"));
+  content_types.Append(new base::StringValue("something/invalid"));
   scoped_refptr<const WebRequestConditionAttribute> attribute_unincluded =
       WebRequestConditionAttribute::Create(
           keys::kContentTypeKey, &content_types, &error);
   EXPECT_EQ("", error);
   ASSERT_TRUE(attribute_unincluded.get());
   EXPECT_FALSE(attribute_unincluded->IsFulfilled(
       WebRequestData(&url_request, ON_HEADERS_RECEIVED,
                      url_request.response_headers())));
 
   scoped_refptr<const WebRequestConditionAttribute> attribute_unexcluded =
@@ skipping 188 matching lines @@
       scoped_ptr<Value> entry_owned;
       ListValue* list = NULL;
       if (!dictionary->GetWithoutPathExpansion(*name, &entry))
         return scoped_ptr<DictionaryValue>();
       switch (entry->GetType()) {
         case Value::TYPE_STRING:  // Replace the present string with a list.
           list = new ListValue;
           // Ignoring return value, we already verified the entry is there.
           dictionary->RemoveWithoutPathExpansion(*name, &entry_owned);
           list->Append(entry_owned.release());
-          list->Append(Value::CreateStringValue(*value));
+          list->Append(new base::StringValue(*value));
           dictionary->SetWithoutPathExpansion(*name, list);
           break;
         case Value::TYPE_LIST:  // Just append to the list.
           CHECK(entry->GetAsList(&list));
-          list->Append(Value::CreateStringValue(*value));
+          list->Append(new base::StringValue(*value));
           break;
         default:
           NOTREACHED();  // We never put other Values here.
           return scoped_ptr<DictionaryValue>();
       }
     } else {
       dictionary->SetString(*name, *value);
     }
   }
   return dictionary.Pass();
@@ skipping 287 matching lines @@
     keys::kValueEqualsKey, "valueB"
   };
   const size_t kExistingSize[] = { arraysize(kExisting) };
   GetArrayAsVector(kExisting, kExistingSize, 1u, &tests);
   MatchAndCheck(
       tests, keys::kExcludeResponseHeadersKey, stage, &url_request, &result);
   EXPECT_FALSE(result);
 }
 
 }  // namespace extensions