Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/wtf/Assertions.h

Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity). (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/allocator/partition_allocator/partition_alloc.h ('K') | « build/config/dcheck_always_on.gni ('k') | third_party/WebKit/Source/wtf/AssertionsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/Assertions.h
diff --git a/third_party/WebKit/Source/wtf/Assertions.h b/third_party/WebKit/Source/wtf/Assertions.h
index 392b24d8881aeb93f89cf69727cba73b6de52c96..1651615c4d0894e68b803d1d438ff84abec53a66 100644
--- a/third_party/WebKit/Source/wtf/Assertions.h
+++ b/third_party/WebKit/Source/wtf/Assertions.h
@@ -142,9 +142,10 @@ class WTF_EXPORT ScopedLogger {
#undef ASSERT
#endif
-#define DCHECK_AT(assertion, file, line) \
- LAZY_STREAM(logging::LogMessage(file, line, #assertion).stream(), \
- DCHECK_IS_ON() ? !(assertion) : false)
+#define DCHECK_AT(assertion, file, line) \
+ LAZY_STREAM(logging::LogMessage(file, line, logging::LOG_DCHECK).stream(), \
+ DCHECK_IS_ON() ? !(assertion) : false) \
+ << "Check failed: " #assertion ". "
#if DCHECK_IS_ON()
#define ASSERT(assertion) DCHECK(assertion)
« base/allocator/partition_allocator/partition_alloc.h ('K') | « build/config/dcheck_always_on.gni ('k') | third_party/WebKit/Source/wtf/AssertionsTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698