Implement Dump-on-DCHECK (via a new LogSeverity).

base/test/gtest_util.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TEST_GTEST_UTIL_H_
 #define BASE_TEST_GTEST_UTIL_H_
 
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // EXPECT/ASSERT_DCHECK_DEATH is intended to replace EXPECT/ASSERT_DEBUG_DEATH
 // when the death is expected to be caused by a DCHECK. Contrary to
 // EXPECT/ASSERT_DEBUG_DEATH however, it doesn't execute the statement in non-
 // dcheck builds as DCHECKs are intended to catch things that should never
 // happen and as such executing the statement results in undefined behavior
 // (|statement| is compiled in unsupported configurations nonetheless).
 // Death tests misbehave on Android.
-#if DCHECK_IS_ON() && defined(GTEST_HAS_DEATH_TEST) && !defined(OS_ANDROID)
+#if DCHECK_IS_ON() && defined(GTEST_HAS_DEATH_TEST) && !defined(OS_ANDROID) && !defined(DCHECK_IS_DUMP_WITHOUT_CRASH)

[Wez, 2016/12/19 23:57:46]

This causes EXPECT_DCHECK_DEATH to be a no-op if DCHECK is defined to
dump-on-DCHECK. For some tests we could still have them work, and just verify
that dump-without-crashing gets called.  For others the DCHECKs actually protect
against e.g. C++ data-structure corruption, so we'll crash anyway if we don't
have DCHECK crash.

Q: Is there any down-side to losing this test coverage in dump-on-DCHECK builds?

 
 // EXPECT/ASSERT_DCHECK_DEATH tests verify that a DCHECK is hit ("Check failed"
 // is part of the error message), but intentionally do not expose the gtest
 // death test's full |regex| parameter to avoid users having to verify the exact
 // syntax of the error message produced by the DCHECK.
 #define EXPECT_DCHECK_DEATH(statement) EXPECT_DEATH(statement, "Check failed")
 #define ASSERT_DCHECK_DEATH(statement) ASSERT_DEATH(statement, "Check failed")
 
 #else
 // DCHECK_IS_ON() && defined(GTEST_HAS_DEATH_TEST) && !defined(OS_ANDROID)
 
 // Macro copied from gtest-death-test-internal.h as it's (1) internal for now
 // and (2) only defined if !GTEST_HAS_DEATH_TEST which is only a subset of the
 // conditions in which it's needed here.
 // TODO(gab): Expose macro in upstream gtest repo for consumers like us that
 // want more specific death tests and remove this hack.
 # define GTEST_UNSUPPORTED_DEATH_TEST(statement, regex, terminator) \
     GTEST_AMBIGUOUS_ELSE_BLOCKER_ \
     if (::testing::internal::AlwaysTrue()) { \
       GTEST_LOG_(WARNING) \
-          << "Death tests are not supported on this platform.\n" \
+          << "Death tests are not supported in this configuration.\n" \
           << "Statement '" #statement "' cannot be verified."; \
     } else if (::testing::internal::AlwaysFalse()) { \
       ::testing::internal::RE::PartialMatch(".*", (regex)); \
       GTEST_SUPPRESS_UNREACHABLE_CODE_WARNING_BELOW_(statement); \
       terminator; \
     } else \
       ::testing::Message()
 
 #define EXPECT_DCHECK_DEATH(statement) \
     GTEST_UNSUPPORTED_DEATH_TEST(statement, "Check failed", )
@@ skipping 37 matching lines @@
 
 // Reads the list of gtest-based tests from |path| into |output|.
 // Returns true on success.
 bool ReadTestNamesFromFile(
     const FilePath& path,
     std::vector<TestIdentifier>* output) WARN_UNUSED_RESULT;
 
 }  // namespace base
 
 #endif  // BASE_TEST_GTEST_UTIL_H_