Implement Dump-on-DCHECK (via a new LogSeverity).

base/logging_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/compiler_specific.h"
+#include "base/debug/dump_without_crashing.h"
 #include "base/logging.h"
 #include "base/macros.h"
 
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace logging {
 
 namespace {
 
@@ skipping 168 matching lines @@
   PCHECK(!mock_log_source.Log()) << mock_log_source.Log();
   CHECK_EQ(mock_log_source.Log(), mock_log_source.Log())
       << uncalled_mock_log_source.Log();
   CHECK_NE(mock_log_source.Log(), mock_log_source.Log())
       << mock_log_source.Log();
 }
 
 #endif
 
 TEST_F(LoggingTest, DebugLoggingReleaseBehavior) {
-#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
+#if DCHECK_IS_ON()
   int debug_only_variable = 1;
 #endif
   // These should avoid emitting references to |debug_only_variable|
   // in release mode.
   DLOG_IF(INFO, debug_only_variable) << "test";
   DLOG_ASSERT(debug_only_variable) << "test";
   DPLOG_IF(INFO, debug_only_variable) << "test";
   DVLOG_IF(1, debug_only_variable) << "test";
 }
 
@@ skipping 114 matching lines @@
   if (false)
     CHECK_EQ(false, true);           // Unreached.
   else
     CHECK_EQ(true, reached = true);  // Reached, passed.
   ASSERT_TRUE(reached);
 
   if (false)
     CHECK_EQ(false, true);           // Unreached.
 }
 
+namespace {
+
+int fake_dump_without_crashing_count = 0;
+void FakeDumpWithoutCrashing() {
+  fake_dump_without_crashing_count++;
+}
+
+} // namespace
+
+TEST_F(LoggingTest, LogMessageDump) {
+  // Replace the dump-without-crashing function, to test.
+  base::debug::SetDumpWithoutCrashingFunction(&FakeDumpWithoutCrashing);
+
+  // LOG_DUMP is an internal severity level for use by dump-on-DCHECK, so
+  // we must call LogMessage() directly, rather than using LOG(DUMP).
+  LogMessage(__FILE__, __LINE__, LOG_DUMP, new std::string);
+  EXPECT_EQ(1, fake_dump_without_crashing_count);
+  LogMessage(__FILE__, __LINE__, LOG_DUMP, new std::string);
+  EXPECT_EQ(1, fake_dump_without_crashing_count);
+
+  base::debug::SetDumpWithoutCrashingFunction(nullptr);
+}
+
 // Test that defining an operator<< for a type in a namespace doesn't prevent
 // other code in that namespace from calling the operator<<(ostream, wstring)
 // defined by logging.h. This can fail if operator<<(ostream, wstring) can't be
 // found by ADL, since defining another operator<< prevents name lookup from
 // looking in the global namespace.
 namespace nested_test {
   class Streamable {};
   ALLOW_UNUSED_TYPE std::ostream& operator<<(std::ostream& out,
                                              const Streamable&) {
     return out << "Streamable";
   }
   TEST_F(LoggingTest, StreamingWstringFindsCorrectOperator) {
     std::wstring wstr = L"Hello World";
     std::ostringstream ostr;
     ostr << wstr;
     EXPECT_EQ("Hello World", ostr.str());
   }
 }  // namespace nested_test
 
 }  // namespace
 
 }  // namespace logging