Make source map paths relative

Make source map paths relative

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/376489cc63c7aade58013307b3f28fcb41b98b9b

[vsm, 2016-08-26 22:55:59]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2016-08-26 23:06:37]

hey Vijay, I think we have a bug somewhere else, maybe this regressed as a
result of that last modules CL. I think this isn't the right way to fix it but
it's close.

https://codereview.chromium.org/2288453002/diff/20001/lib/src/compiler/compil...
File lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2288453002/diff/20001/lib/src/compiler/compil...
lib/src/compiler/compiler.dart:366: // Assume these are in the same directory
and use relative paths.
I don't understand why we need this assumption. Can't you just make the URIs
relative to each other?

see placeSourceMap's `path.toUri(path.relative(path.fromUri(list[i]), from:
dir)).toString()` code, is it not working?

https://codereview.chromium.org/2288453002/diff/20001/lib/src/compiler/compil...
lib/src/compiler/compiler.dart:373: builtMap =
placeSourceMap(sourceMap.build(path.basename(jsUrl)), mapUrl);
here too, I don't see why this is needed, the whole point of placeSourceMap is
to do this relative path adjustment.

[vsm, 2016-08-26 23:19:48]

thanks - ptal

https://codereview.chromium.org/2288453002/diff/20001/lib/src/compiler/compil...
File lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2288453002/diff/20001/lib/src/compiler/compil...
lib/src/compiler/compiler.dart:366: // Assume these are in the same directory
and use relative paths.
On 2016/08/26 23:06:37, John Messerly wrote:
> I don't understand why we need this assumption. Can't you just make the URIs
> relative to each other?
> 
> see placeSourceMap's `path.toUri(path.relative(path.fromUri(list[i]), from:
> dir)).toString()` code, is it not working?

Done.

https://codereview.chromium.org/2288453002/diff/20001/lib/src/compiler/compil...
lib/src/compiler/compiler.dart:373: builtMap =
placeSourceMap(sourceMap.build(path.basename(jsUrl)), mapUrl);
On 2016/08/26 23:06:37, John Messerly wrote:
> here too, I don't see why this is needed, the whole point of placeSourceMap is
> to do this relative path adjustment.

done - see below.

[Jennifer Messerly, 2016-08-26 23:24:30]

lgtm!

[vsm, 2016-08-26 23:32:00]

Description was changed from

==========
Make source map paths relative
==========

to

==========
Make source map paths relative

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/376489cc63c7aade58013307b3f2...
==========

[vsm, 2016-08-26 23:32:01]

Committed patchset #4 (id:60001) manually as
376489cc63c7aade58013307b3f28fcb41b98b9b (presubmit successful).