Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 228843002: IndexedDBTransactionTest::Timeout now calls Timeout(). (Closed)

Created:
6 years, 8 months ago by cmumford
Modified:
6 years, 8 months ago
Reviewers:
dgrogan
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

IndexedDBTransactionTest::Timeout now calls Timeout(). When the transaction timeout expires Timeout is called, which in turn calls Abort(). Making the test a friend so that Timeout can be called makes this a more realistic test. Also checking for correct diagnostic values. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262797

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed out-of-date comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M content/browser/indexed_db/indexed_db_transaction.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction_unittest.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
cmumford
This change didn't fix anything, it was just one of several new or enhanced tests ...
6 years, 8 months ago (2014-04-08 16:01:28 UTC) #1
dgrogan
lgtm https://codereview.chromium.org/228843002/diff/1/content/browser/indexed_db/indexed_db_transaction_unittest.cc File content/browser/indexed_db/indexed_db_transaction_unittest.cc (right): https://codereview.chromium.org/228843002/diff/1/content/browser/indexed_db/indexed_db_transaction_unittest.cc#newcode78 content/browser/indexed_db/indexed_db_transaction_unittest.cc:78: // Abort should cancel the timer. Fix or ...
6 years, 8 months ago (2014-04-09 00:59:58 UTC) #2
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 8 months ago (2014-04-09 16:05:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/228843002/20001
6 years, 8 months ago (2014-04-09 16:05:49 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 17:36:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-09 17:36:57 UTC) #6
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 8 months ago (2014-04-09 19:06:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/228843002/20001
6 years, 8 months ago (2014-04-09 19:07:21 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 20:28:43 UTC) #9
Message was sent while issue was closed.
Change committed as 262797

Powered by Google App Engine
This is Rietveld 408576698