Issue 22884003: Enable native custom elements for Pica benchmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22884003: Enable native custom elements for Pica benchmark (Closed)

Created:
7 years, 4 months ago by adamk

Modified:
7 years, 4 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, dominicc (has gone to gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable native custom elements for Pica benchmark R=tonyg@chromium.org BUG=245358 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217042

Patch Set 2 : Avoid dups #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tools/perf/benchmarks/pica.py	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tonyg

lgtm https://codereview.chromium.org/22884003/diff/1/tools/perf/benchmarks/pica.py File tools/perf/benchmarks/pica.py (right): https://codereview.chromium.org/22884003/diff/1/tools/perf/benchmarks/pica.py#newcode11 tools/perf/benchmarks/pica.py:11: options.extra_browser_args.append( Please use options.AppendExtraBrowserArg(). It checks for duplicates.

7 years, 4 months ago (2013-08-12 18:15:10 UTC) #2

adamk

https://codereview.chromium.org/22884003/diff/1/tools/perf/benchmarks/pica.py File tools/perf/benchmarks/pica.py (right): https://codereview.chromium.org/22884003/diff/1/tools/perf/benchmarks/pica.py#newcode11 tools/perf/benchmarks/pica.py:11: options.extra_browser_args.append( On 2013/08/12 18:15:10, tonyg wrote: > Please use ...

7 years, 4 months ago (2013-08-12 18:20:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r217042.

Expand Messages | Collapse Messages

Issue 22884003: Enable native custom elements for Pica benchmark (Closed)

Description

Patch Set 1 #

Patch Set 2 : Avoid dups #

Messages