Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 2288393002: Simplify the bailout test for generic inference (Closed)

Created:
3 years, 1 month ago by Jennifer Messerly
Modified:
3 years, 1 month ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Simplify the bailout test for generic inference Just tidies up two checks that should be one check, and some vestigial substitution. Noticed this while working on #26992 R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/562c5e132849bb049f8551ec60b042e37917387e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
3 years, 1 month ago (2016-08-29 20:41:08 UTC) #2
Leaf
lgtm
3 years, 1 month ago (2016-08-29 21:06:10 UTC) #4
Jennifer Messerly
3 years, 1 month ago (2016-08-29 23:42:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
562c5e132849bb049f8551ec60b042e37917387e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698