Disable CJK specific generic font families for monospace on Android

Disable CJK specific generic font families for monospace on Android

Before this patch, when the content locale is one of CJK, Android maps
all generic families to what Skia matchFamilyStyleCharacter() API
returns. This API can find one default font for the specified locale,
but disregards which generic font family was used.

This patch disables the behavior for "monospace", where using the
monospace ASCII glyphs is more important than using the font that has
good coverage of the specified locale.

When characters outside of the monospace font were used, system
fallback can still help to render the characters.

BUG=640077
Committed: https://crrev.com/96e2aeba7ca3d4398a2cfb44f2b864dfa8ea2ad9
Cr-Commit-Position: refs/heads/master@{#415287}

[kojii, 2016-08-29 19:21:11]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 19:54:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:41:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:41:47]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-08-30 03:47:08]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 03:49:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-08-30 04:44:37]

Description was changed from

==========
monospace-android

BUG=
==========

to

==========
Disable CJK specific generic font families for monospace on Android

Before this patch, when the content locale is one of CJK, Android maps
all generic families to what Skia matchFamilyStyleCharacter() API
returns. This API can find one default font for the specified locale,
but disregards which generic font family was used.

This patch disables the behavior for "monospace", where using the
monospace ASCII glyphs is more important than using the font that has
good coverage of the specified locale.

When characters outside of the monospace font were used, system
fallback can still help to render the characters.

BUG=640077
==========

[commit-bot: I haz the power, 2016-08-30 05:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 05:27:50]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-08-30 05:58:50]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 05:59:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-08-30 05:59:39]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[kojii, 2016-08-30 05:59:40]

PTAL.

[commit-bot: I haz the power, 2016-08-30 07:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 07:23:28]

Dry run: This issue passed the CQ dry run.

[drott, 2016-08-30 08:18:58]

LGTM if you file a bug to keep track of improving this in fonts.xml. Thanks.

https://codereview.chromium.org/2288383002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/android/FontCacheAndroid.cpp
(right):

https://codereview.chromium.org/2288383002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/android/FontCacheAndroid.cpp:57: //
fallback can still render the characters.
Looks okay to me but let's file a bug to keep track of this and find a better
way to encode such choices in fonts.xml. Would be great if you could follow up
with the Android fonts people on what should be the best way to address this
problem.

[kojii, 2016-08-30 12:45:09]

On 2016/08/30 at 08:18:58, drott wrote:
> Looks okay to me but let's file a bug to keep track of this and find a better
way to encode such choices in fonts.xml. Would be great if you could follow up
with the Android fonts people on what should be the best way to address this
problem.

Filed crbug.com/642340, not sure whether we should start with Skia or Android,
let's see how it goes. I'll update the comment to refer to the bug.

[kojii, 2016-08-30 12:49:29]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-08-30 12:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org
Link to the patchset: https://codereview.chromium.org/2288383002/#ps60001
(title: "drott review, updated comments")

[commit-bot: I haz the power, 2016-08-30 12:49:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 14:02:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-30 14:04:10]

Description was changed from

==========
Disable CJK specific generic font families for monospace on Android

Before this patch, when the content locale is one of CJK, Android maps
all generic families to what Skia matchFamilyStyleCharacter() API
returns. This API can find one default font for the specified locale,
but disregards which generic font family was used.

This patch disables the behavior for "monospace", where using the
monospace ASCII glyphs is more important than using the font that has
good coverage of the specified locale.

When characters outside of the monospace font were used, system
fallback can still help to render the characters.

BUG=640077
==========

to

==========
Disable CJK specific generic font families for monospace on Android

Before this patch, when the content locale is one of CJK, Android maps
all generic families to what Skia matchFamilyStyleCharacter() API
returns. This API can find one default font for the specified locale,
but disregards which generic font family was used.

This patch disables the behavior for "monospace", where using the
monospace ASCII glyphs is more important than using the font that has
good coverage of the specified locale.

When characters outside of the monospace font were used, system
fallback can still help to render the characters.

BUG=640077

Committed: https://crrev.com/96e2aeba7ca3d4398a2cfb44f2b864dfa8ea2ad9
Cr-Commit-Position: refs/heads/master@{#415287}
==========

[commit-bot: I haz the power, 2016-08-30 14:04:11]

Patchset 4 (id:??) landed as
https://crrev.com/96e2aeba7ca3d4398a2cfb44f2b864dfa8ea2ad9
Cr-Commit-Position: refs/heads/master@{#415287}

[eae, 2016-08-30 14:54:57]

LGTM