Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2288363002: Render the root view in NewTabPageTest.testRender(). (Closed)

Created:
4 years, 3 months ago by PEConn
Modified:
4 years, 3 months ago
Reviewers:
Ted C, mdjones, jbudorick
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Render the root view in NewTabPageTest.testRender(). By rendering the root view we include the Toolbar in the new_tab_page renders. BUG=641975 Committed: https://crrev.com/15e51abda1ade941307298d75621affff75960ff Cr-Commit-Position: refs/heads/master@{#415144}

Patch Set 1 #

Messages

Total messages: 10 (3 generated)
PEConn
jbudorick@chromium.org: Please review changes in RenderUtils.java tedchoc@chromium.org: Please review changes in mdjones@chromium.org: Please review changes ...
4 years, 3 months ago (2016-08-29 18:58:14 UTC) #2
mdjones
lgtm
4 years, 3 months ago (2016-08-29 20:21:12 UTC) #3
Ted C
On 2016/08/29 20:21:12, mdjones wrote: > lgtm rs lgtm
4 years, 3 months ago (2016-08-29 21:26:14 UTC) #4
jbudorick
lgtm
4 years, 3 months ago (2016-08-29 22:12:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288363002/1
4 years, 3 months ago (2016-08-29 22:59:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 05:16:45 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:20:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15e51abda1ade941307298d75621affff75960ff
Cr-Commit-Position: refs/heads/master@{#415144}

Powered by Google App Engine
This is Rietveld 408576698