Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 2288353002: Replace references to OffTheRecord from OffTheRecordTabModel to Incognito (Closed)

Created:
4 years, 3 months ago by chili
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace references to OffTheRecord from OffTheRecordTabModel to Incognito BUG=3333 Committed: https://crrev.com/db88560b0dd7c0eb6e6994f233a4994e52177aef Cr-Commit-Position: refs/heads/master@{#415517}

Patch Set 1 #

Patch Set 2 : git oopsie #

Patch Set 3 : actually rename to right thing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -334 lines) Patch
A + chrome/android/java/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModel.java View 1 3 chunks +10 lines, -10 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/tabmodel/OffTheRecordTabModel.java View 1 chunk +0 lines, -244 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/OffTheRecordTabModelImplCreator.java View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelSelector.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/OffTheRecordDocumentTabModel.java View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModelTest.java View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/OffTheRecordTabModelTest.java View 2 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (23 generated)
chili
4 years, 3 months ago (2016-08-31 00:08:17 UTC) #21
gone
lgtm
4 years, 3 months ago (2016-08-31 00:17:55 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288353002/80001
4 years, 3 months ago (2016-08-31 00:30:44 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 3 months ago (2016-08-31 00:35:47 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 00:38:21 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/db88560b0dd7c0eb6e6994f233a4994e52177aef
Cr-Commit-Position: refs/heads/master@{#415517}

Powered by Google App Engine
This is Rietveld 408576698