Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: content/renderer/render_widget.cc

Issue 2288313002: Return the WebViewFrameWidget in RenderWidget::webwidget() if there (Closed)
Patch Set: fix one more test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index c1852580d53261779ba4cb4bdcfdf9b756c4120d..db3936a95158649aef3ea577dbbc193206e54161 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -1071,7 +1071,7 @@ void RenderWidget::Resize(const ResizeParams& params) {
visual_viewport_size = visible_viewport_size_;
}
- webwidget()->resizeVisualViewport(visual_viewport_size);
+ GetWebWidget()->resizeVisualViewport(visual_viewport_size);
// When resizing, we want to wait to paint before ACK'ing the resize. This
// ensures that we only resize as fast as we can paint. We only need to
@@ -1144,8 +1144,8 @@ void RenderWidget::WillCloseLayerTreeView() {
// Always send this notification to prevent new layer tree views from
// being created, even if one hasn't been created yet.
- if (webwidget_)
- webwidget_->willCloseLayerTreeView();
+ if (GetWebWidget())
+ GetWebWidget()->willCloseLayerTreeView();
}
blink::WebLayerTreeView* RenderWidget::layerTreeView() {
@@ -1381,16 +1381,16 @@ void RenderWidget::OnImeSetComposition(
}
#endif
if (replacement_range.IsValid()) {
- webwidget_->applyReplacementRange(replacement_range.start(),
- replacement_range.length());
+ GetWebWidget()->applyReplacementRange(replacement_range.start(),
+ replacement_range.length());
}
if (!ShouldHandleImeEvent())
return;
ImeEventGuard guard(this);
- if (!webwidget_->setComposition(
- text, WebVector<WebCompositionUnderline>(underlines),
- selection_start, selection_end)) {
+ if (!GetWebWidget()->setComposition(
+ text, WebVector<WebCompositionUnderline>(underlines), selection_start,
+ selection_end)) {
// If we failed to set the composition text, then we need to let the browser
// process to cancel the input method's ongoing composition session, to make
// sure we are in a consistent state.
@@ -1410,8 +1410,8 @@ void RenderWidget::OnImeConfirmComposition(const base::string16& text,
}
#endif
if (replacement_range.IsValid()) {
- webwidget_->applyReplacementRange(replacement_range.start(),
- replacement_range.length());
+ GetWebWidget()->applyReplacementRange(replacement_range.start(),
+ replacement_range.length());
}
if (!ShouldHandleImeEvent())
@@ -1419,11 +1419,11 @@ void RenderWidget::OnImeConfirmComposition(const base::string16& text,
ImeEventGuard guard(this);
input_handler_->set_handling_input_event(true);
if (text.length())
- webwidget_->confirmComposition(text);
+ GetWebWidget()->confirmComposition(text);
else if (keep_selection)
- webwidget_->confirmComposition(WebWidget::KeepSelection);
+ GetWebWidget()->confirmComposition(WebWidget::KeepSelection);
else
- webwidget_->confirmComposition(WebWidget::DoNotKeepSelection);
+ GetWebWidget()->confirmComposition(WebWidget::DoNotKeepSelection);
input_handler_->set_handling_input_event(false);
UpdateCompositionInfo(false /* not an immediate request */);
}
@@ -1439,7 +1439,7 @@ void RenderWidget::OnDeviceScaleFactorChanged() {
void RenderWidget::OnRepaint(gfx::Size size_to_paint) {
// During shutdown we can just ignore this message.
- if (!webwidget_)
+ if (!GetWebWidget())
return;
// Even if the browser provides an empty damage rect, it's still expecting to
@@ -1461,9 +1461,9 @@ void RenderWidget::OnSyntheticGestureCompleted() {
}
void RenderWidget::OnSetTextDirection(WebTextDirection direction) {
- if (!webwidget_)
+ if (!GetWebWidget())
return;
- webwidget_->setTextDirection(direction);
+ GetWebWidget()->setTextDirection(direction);
}
void RenderWidget::OnUpdateScreenRects(const gfx::Rect& view_screen_rect,
@@ -1505,8 +1505,8 @@ ui::TextInputType RenderWidget::GetTextInputType() {
if (focused_pepper_plugin_)
return focused_pepper_plugin_->text_input_type();
#endif
- if (webwidget_)
- return WebKitToUiTextInputType(webwidget_->textInputType());
+ if (GetWebWidget())
+ return WebKitToUiTextInputType(GetWebWidget()->textInputType());
return ui::TEXT_INPUT_TYPE_NONE;
}
@@ -1598,7 +1598,7 @@ void RenderWidget::OnRequestCompositionUpdate(bool immediate_request,
bool RenderWidget::ShouldHandleImeEvent() {
#if defined(OS_ANDROID)
- if (!webwidget_)
+ if (!GetWebWidget())
return false;
if (IsUsingImeThread())
return true;
@@ -1615,7 +1615,7 @@ bool RenderWidget::ShouldHandleImeEvent() {
}
return true;
#else
- return !!webwidget_;
+ return !!GetWebWidget();
#endif
}
@@ -1671,13 +1671,13 @@ void RenderWidget::SetHidden(bool hidden) {
}
void RenderWidget::DidToggleFullscreen() {
- if (!webwidget_)
+ if (!GetWebWidget())
return;
if (is_fullscreen_granted_) {
- webwidget_->didEnterFullscreen();
+ GetWebWidget()->didEnterFullscreen();
} else {
- webwidget_->didExitFullscreen();
+ GetWebWidget()->didExitFullscreen();
}
}
@@ -1748,7 +1748,7 @@ void RenderWidget::GetSelectionBounds(gfx::Rect* focus, gfx::Rect* anchor) {
#endif
WebRect focus_webrect;
WebRect anchor_webrect;
- webwidget_->selectionBounds(focus_webrect, anchor_webrect);
+ GetWebWidget()->selectionBounds(focus_webrect, anchor_webrect);
convertViewportToWindow(&focus_webrect);
convertViewportToWindow(&anchor_webrect);
*focus = focus_webrect;
@@ -1757,7 +1757,7 @@ void RenderWidget::GetSelectionBounds(gfx::Rect* focus, gfx::Rect* anchor) {
void RenderWidget::UpdateSelectionBounds() {
TRACE_EVENT0("renderer", "RenderWidget::UpdateSelectionBounds");
- if (!webwidget_)
+ if (!GetWebWidget())
return;
if (ime_event_guard_)
return;
@@ -1782,8 +1782,9 @@ void RenderWidget::UpdateSelectionBounds() {
selection_focus_rect_ != params.focus_rect) {
selection_anchor_rect_ = params.anchor_rect;
selection_focus_rect_ = params.focus_rect;
- webwidget_->selectionTextDirection(params.focus_dir, params.anchor_dir);
- params.is_anchor_first = webwidget_->isSelectionAnchorFirst();
+ GetWebWidget()->selectionTextDirection(params.focus_dir,
+ params.anchor_dir);
+ params.is_anchor_first = GetWebWidget()->isSelectionAnchorFirst();
Send(new ViewHostMsg_SelectionBoundsChanged(routing_id_, params));
}
}
@@ -1861,10 +1862,10 @@ void RenderWidget::GetCompositionCharacterBounds(
return;
#endif
- if (!webwidget_)
+ if (!GetWebWidget())
return;
blink::WebVector<blink::WebRect> bounds_from_blink;
- if (!webwidget_->getCompositionCharacterBounds(bounds_from_blink))
+ if (!GetWebWidget()->getCompositionCharacterBounds(bounds_from_blink))
return;
for (size_t i = 0; i < bounds_from_blink.size(); ++i) {
@@ -1879,7 +1880,7 @@ void RenderWidget::GetCompositionRange(gfx::Range* range) {
return;
#endif
size_t location, length;
- if (webwidget_->compositionRange(&location, &length)) {
+ if (GetWebWidget()->compositionRange(&location, &length)) {
range->set_start(location);
range->set_end(location + length);
} else {
@@ -1922,7 +1923,7 @@ void RenderWidget::resetInputMethod() {
if (text_input_info_.type != blink::WebTextInputTypeNone) {
// If a composition text exists, then we need to let the browser process
// to cancel the input method's ongoing composition session.
- if (webwidget_->confirmComposition())
+ if (GetWebWidget()->confirmComposition())
Send(new InputHostMsg_ImeCancelComposition(routing_id()));
}
@@ -1954,8 +1955,8 @@ void RenderWidget::didHandleGestureEvent(
if (event.type == WebInputEvent::GestureTap) {
UpdateTextInputState(ShowIme::IF_NEEDED, ChangeSource::FROM_NON_IME);
} else if (event.type == WebInputEvent::GestureLongPress) {
- DCHECK(webwidget_);
- if (webwidget_->textInputInfo().value.isEmpty())
+ DCHECK(GetWebWidget());
+ if (GetWebWidget()->textInputInfo().value.isEmpty())
UpdateTextInputState(ShowIme::HIDE_IME, ChangeSource::FROM_NON_IME);
else
UpdateTextInputState(ShowIme::IF_NEEDED, ChangeSource::FROM_NON_IME);
@@ -2093,4 +2094,8 @@ bool RenderWidget::isPointerLocked() {
webwidget_mouse_lock_target_.get());
}
+blink::WebWidget* RenderWidget::GetWebWidget() const {
+ return webwidget_;
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698