Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2288313002: Return the WebViewFrameWidget in RenderWidget::webwidget() if there (Closed)
Patch Set: avoid virtual call Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index e4e393e1b65a989758380c97dd277ea9832d22cc..f6cf494c7f23776cb06b757f1cb601f59c449254 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1611,7 +1611,7 @@ WebWidget* RenderViewImpl::createPopupMenu(blink::WebPopupType popup_type) {
widget->SetPopupOriginAdjustmentsForEmulation(
screen_metrics_emulator_.get());
}
- return widget->webwidget();
+ return widget->GetWebWidget();
}
WebStorageNamespace* RenderViewImpl::createSessionStorageNamespace() {
@@ -2601,6 +2601,13 @@ void RenderViewImpl::OnSetActive(bool active) {
webview()->setIsActive(active);
}
+blink::WebWidget* RenderViewImpl::GetWebWidget() const {
+ if (frame_widget_)
+ return frame_widget_;
+
+ return RenderWidget::GetWebWidget();
+}
+
void RenderViewImpl::CloseForFrame() {
DCHECK(frame_widget_);
frame_widget_->close();

Powered by Google App Engine
This is Rietveld 408576698