Return the WebViewFrameWidget in RenderWidget::webwidget() if there

third_party/WebKit/Source/web/WebViewFrameWidget.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be found
 // in the LICENSE file.
 
 #ifndef WebViewFrameWidget_h
 #define WebViewFrameWidget_h
 
 #include "platform/heap/Handle.h"
 #include "web/WebFrameWidgetBase.h"
 #include "web/WebLocalFrameImpl.h"
@@ skipping 69 matching lines @@
     bool isAcceleratedCompositingActive() const override;
     bool isWebView() const override { return false; }
     bool isPagePopup() const override { return false; }
     void willCloseLayerTreeView() override;
     void didAcquirePointerLock() override;
     void didNotAcquirePointerLock() override;
     void didLosePointerLock() override;
     void didChangeWindowResizerRect() override;
     WebColor backgroundColor() const override;
     WebPagePopup* pagePopup() const override;
+    bool getCompositionCharacterBounds(WebVector<WebRect>& bounds) override;
+    void applyReplacementRange(int start, int length) override;

[dcheng, 2016/09/08 19:42:16]

How come these lines are in this patch?

[lfg, 2016/09/08 19:58:24]

When they were added, they were added only to WebViewImpl, without being in
WebViewFrameWidget. Since with this patch we are now returning a
WebViewFrameWidget, these calls became a no-op unless we forward them.

BTW, this is exactly what this change tries to prevent.

     void updateTopControlsState(WebTopControlsState constraints, WebTopControlsState current, bool animate) override;
     void setVisibilityState(WebPageVisibilityState) override;
     bool isTransparent() const override;
     void setIsTransparent(bool) override;
     void setBaseBackgroundColor(WebColor) override;
     WebLocalFrameImpl* localRoot() override;
 
     // WebFrameWidgetBase overrides:
     bool forSubframe() const override { return false; }
     void scheduleAnimation() override;
     CompositorProxyClient* createCompositorProxyClient() override;
     void setRootGraphicsLayer(GraphicsLayer*) override;
     void attachCompositorAnimationTimeline(CompositorAnimationTimeline*) override;
     void detachCompositorAnimationTimeline(CompositorAnimationTimeline*) override;
     WebWidgetClient* client() const override { return m_client; }
 
 private:
     WebWidgetClient* m_client;
     RefPtr<WebViewImpl> m_webView;
     Persistent<WebLocalFrameImpl> m_mainFrame;
 };
 
 } // namespace blink
 
 #endif // WebViewFrameWidget_h