tools/telemetry/telemetry/page/page_set.py - Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_set.py

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Putting default navigate_steps inside page_set rather than page Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_set.py

diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py

index 807c365532bb92f4498296e9e08b1be0c37c1085..ce79f388113c359bd0c1249bb38e67107426336f 100644

--- a/tools/telemetry/telemetry/page/page_set.py

+++ b/tools/telemetry/telemetry/page/page_set.py

@@ -17,6 +17,7 @@ class PageSet(object):

self.credentials_path = None

self.user_agent_type = None

self.make_javascript_deterministic = True

+ self.navigate_steps = {'action': 'navigate'}

if attributes:

for k, v in attributes.iteritems():

« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »