tools/telemetry/telemetry/page/actions/tap_element.py - Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/tap_element.py

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Putting default navigate_steps inside page_set rather than page Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/actions/tap_element.py

diff --git a/tools/telemetry/telemetry/page/actions/tap_element.py b/tools/telemetry/telemetry/page/actions/tap_element.py

index f3a4734a20e93023a29cbf01fbdeb1374208c517..f8c669eda7855cfb4a7b9b820e4ff389cf9d6f21 100644

--- a/tools/telemetry/telemetry/page/actions/tap_element.py

+++ b/tools/telemetry/telemetry/page/actions/tap_element.py

@@ -4,7 +4,6 @@

from telemetry.core import exceptions

from telemetry.core import util

-from telemetry.page import page as page_module

from telemetry.page.actions import page_action

class TapElementAction(page_action.PageAction):

@@ -41,5 +40,3 @@ class TapElementAction(page_action.PageAction):

'window.__tap_event_finished'), 60)

else:

DoTap()

- page_module.Page.WaitForPageToLoad(self, tab, 60)

« no previous file with comments | « tools/telemetry/telemetry/page/actions/reload.py ('k') | tools/telemetry/telemetry/page/actions/wait.py » ('j') | no next file with comments »