tools/telemetry/telemetry/page/actions/click_element.py - Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/click_element.py

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Putting default navigate_steps inside page_set rather than page Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/page_sets/tough_canvas_cases.json ('k') | tools/telemetry/telemetry/page/actions/click_element_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/actions/click_element.py

diff --git a/tools/telemetry/telemetry/page/actions/click_element.py b/tools/telemetry/telemetry/page/actions/click_element.py

index 78911537fb5ecfea658a65162590845345456478..7ff2dc4524504880aa26f52258a78bd9df94e00e 100644

--- a/tools/telemetry/telemetry/page/actions/click_element.py

+++ b/tools/telemetry/telemetry/page/actions/click_element.py

@@ -6,7 +6,6 @@ import re

from telemetry.core import util

from telemetry.core import exceptions

-from telemetry.page import page as page_module

from telemetry.page.actions import page_action

class ClickElementAction(page_action.PageAction):

@@ -45,15 +44,5 @@ class ClickElementAction(page_action.PageAction):

raise page_action.PageActionFailed(

'No condition given to click_element')

- if hasattr(self, 'wait_for_navigate'):

- tab.PerformActionAndWaitForNavigate(DoClick)

- elif hasattr(self, 'wait_for_href_change'):

- old_url = tab.EvaluateJavaScript('document.location.href')

- DoClick()

- util.WaitFor(lambda: tab.EvaluateJavaScript(

- 'document.location.href') != old_url, 60)

- else:

- DoClick()

- page_module.Page.WaitForPageToLoad(self, tab, 60)

+ DoClick()

tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()

« no previous file with comments | « tools/perf/page_sets/tough_canvas_cases.json ('k') | tools/telemetry/telemetry/page/actions/click_element_unittest.py » ('j') | no next file with comments »