tools/perf/page_sets/pica.json - Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/pica.json

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Putting default navigate_steps inside page_set rather than page Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/pica.json

diff --git a/tools/perf/page_sets/pica.json b/tools/perf/page_sets/pica.json

index 2315276805a04eec9bd2cfceaf074c15fea65701..11527f617e260a542f896a397cbe245f7dc21038 100644

--- a/tools/perf/page_sets/pica.json

+++ b/tools/perf/page_sets/pica.json

@@ -5,7 +5,10 @@

{ "url": "http://www.polymer-project.org/polymer-all/projects/pica/index.html",

"script_to_evaluate_on_commit":

"document.addEventListener('WebComponentsReady', function(){var unused = document.body.offsetHeight; window.__pica_load_time = performance.now(); setTimeout(function(){window.__web_components_ready=true}, 1000)})",

- "wait_for_javascript_expression": "window.__web_components_ready",

+ "navigate_steps" : [

+ { "action": "navigate" },

+ { "action": "wait", "javascript": "window.__web_components_ready" }

+ ],

"smoothness": {

"action": "tap_element",

"find_element_expression": "document.querySelector('pi-app').$.Topics.$.topics.$.container.querySelector('.item > .card')",

« no previous file with comments | « tools/perf/page_sets/mobile_memory.json ('k') | tools/perf/page_sets/top_10.json » ('j') | no next file with comments »