Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/perf/page_sets/key_desktop_sites.json

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Putting default navigate_steps inside page_set rather than page Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/image_decoding_measurement.json ('k') | tools/perf/page_sets/key_mobile_sites.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/key_desktop_sites.json
diff --git a/tools/perf/page_sets/key_desktop_sites.json b/tools/perf/page_sets/key_desktop_sites.json
index 85b05e80734583f4487bb753e397ab4f72b53735..69613a28b0a05880dcf1674580529ae14dbc2254 100644
--- a/tools/perf/page_sets/key_desktop_sites.json
+++ b/tools/perf/page_sets/key_desktop_sites.json
@@ -620,10 +620,10 @@
"url": "https://mail.google.com/mail/",
"credentials": "google",
"scrollable_element_function": "function(callback) { gmonkey.load('2.0', function(api) { callback(api.getScrollableElement()); }); }",
- "smoothness": {
- "action": "scroll",
- "wait_for_javascript_expression": "window.gmonkey !== undefined && document.getElementById('gb') !== null"
- }
+ "smoothness": [
+ { "action": "scroll" },
+ { "action": "wait", "javascript": "window.gmonkey !== undefined && document.getElementById('gb') !== null" }
+ ]
},
{
"url": "https://www.google.com/calendar/",
@@ -634,19 +634,19 @@
"url": "https://drive.google.com",
"credentials": "google",
"scrollable_element_function": "function(callback) { callback(document.getElementsByClassName('doclistview-list')[0]); }",
- "smoothness": {
- "action": "scroll",
- "wait_for_javascript_expression": "document.getElementsByClassName('doclistview-list').length"
- }
+ "smoothness": [
+ { "action": "scroll" },
+ { "action": "wait", "javascript": "document.getElementsByClassName('doclistview-list').length" }
+ ]
},
{
"url": "https://docs.google.com/a/google.com/document/d/1XMAtPiVFZfItsMUOYl39v5YA8bcSPe4LDrVO25OdsCU/edit",
"credentials": "google",
"scrollable_element_function": "function(callback) { callback(document.getElementsByClassName('kix-appview-editor')[0]); }",
- "smoothness": {
- "action": "scroll",
- "wait_for_javascript_expression": "document.getElementsByClassName('kix-appview-editor').length"
- }
+ "smoothness": [
+ { "action": "scroll" },
+ { "action": "wait", "javascript": "document.getElementsByClassName('kix-appview-editor').length" }
+ ]
},
{ "url": "https://maps.google.com" },
{ "url": "http://reader.google.com" },
« no previous file with comments | « tools/perf/page_sets/image_decoding_measurement.json ('k') | tools/perf/page_sets/key_mobile_sites.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698