Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: tools/perf/page_sets/calendar_forward_backward.json

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Putting default navigate_steps inside page_set rather than page Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/2012Q3.json ('k') | tools/perf/page_sets/image_decoding_measurement.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/calendar_forward_backward.json
diff --git a/tools/perf/page_sets/calendar_forward_backward.json b/tools/perf/page_sets/calendar_forward_backward.json
index 7e5257ff846f1d8f642c65809cd72d3209f5fc4a..5b72a253a8fc997227fb1244cb83272b8da1fbcc 100644
--- a/tools/perf/page_sets/calendar_forward_backward.json
+++ b/tools/perf/page_sets/calendar_forward_backward.json
@@ -8,58 +8,29 @@
"url": "https://www.google.com/calendar/",
"why": "Click forward(4x) and backwards(4x) repeatedly",
"credentials": "google",
- "wait_for_element_with_selector": "div[class~=\"navForward\"]",
- "post_navigate_javascript_to_execute": "(function() { var elem = document.createElement('meta');elem.name='viewport';elem.content='initial-scale=1';document.body.appendChild(elem); })();",
- "wait_seconds": 2,
+ "navigate_steps" : [
+ { "action": "navigate" },
+ { "action": "wait", "seconds": 2 },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "javascript", "expression": "(function() { var elem = document.createElement('meta');elem.name='viewport';elem.content='initial-scale=1';document.body.appendChild(elem); })();" }
+ ],
"endure": [
- {
- "action": "click_element",
- "selector": "div[class~=\"navForward\"]",
- "wait_seconds": 2,
- "wait_for_element_with_selector": "div[class~=\"navForward\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navForward\"]",
- "wait_seconds": 2,
- "wait_for_element_with_selector": "div[class~=\"navForward\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navForward\"]",
- "wait_seconds": 2,
- "wait_for_element_with_selector": "div[class~=\"navForward\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navForward\"]",
- "wait_seconds": 2,
- "wait_for_element_with_selector": "div[class~=\"navBack\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navBack\"]",
- "wait_seconds": 2,
- "wait_for_element_with_selector": "div[class~=\"navBack\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navBack\"]",
- "wait_seconds": 2,
- "wait_for_element_with_selector": "div[class~=\"navBack\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navBack\"]",
- "wait_seconds": 2,
- "wait_for_element_with_selector": "div[class~=\"navBack\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navBack\"]",
- "wait_seconds": 2,
- "wait_for_element_with_selector": "div[class~=\"navForward\"]"
- }
+ { "action": "click_element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]" }
]
}
]
« no previous file with comments | « tools/perf/page_sets/2012Q3.json ('k') | tools/perf/page_sets/image_decoding_measurement.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698