tools/telemetry/telemetry/page/page_runner.py - Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/page/page.py ('K') | « tools/telemetry/telemetry/page/page.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | tools/telemetry/telemetry/page/page_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index 4687e42e6abebc08fa88f2d4ff6a04b57f2b7f5d..9ff806fcee51d140fa8b01abedb7ef1eb7f52158 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -138,7 +138,6 @@ class PageState(object):

else:

i = navigate.NavigateAction()

i.RunAction(page, tab, None)

- page.WaitToLoad(tab, 60)

def CleanUpPage(self, page, tab):

if page.credentials and self._did_login: