Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: tools/perf/page_sets/top_10.json

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/top_10.json
diff --git a/tools/perf/page_sets/top_10.json b/tools/perf/page_sets/top_10.json
index b14ae24b49594fa0756625325c0ae9a076c8d9a7..46b050d619d566546f41bf8f3888810abdcd8c02 100644
--- a/tools/perf/page_sets/top_10.json
+++ b/tools/perf/page_sets/top_10.json
@@ -8,26 +8,38 @@
{
"url": "https://www.google.com/#hl=en&q=barack+obama",
"why": "top google property; a google tab is often open",
- "wait_for_element_with_text": "Next"
+ "navigate_steps" : [
+ { "action": "navigate" },
+ { "action": "wait", "condition": "element", "text": "Next"}
+ ]
},
{
"url": "https://mail.google.com/mail/",
"why": "productivity, top google properties",
"credentials": "google",
- "wait_for_javascript_expression": "window.gmonkey !== undefined && document.getElementById('gb') !== null"
+ "navigate_steps" : [
+ { "action": "navigate" },
+ { "action": "wait", "condition": "javascript", "javascript": "window.gmonkey !== undefined && document.getElementById('gb') !== null"}
+ ]
},
{
"url": "https://www.google.com/calendar/",
"why": "productivity, top google properties",
"credentials": "google",
- "wait_for_element_with_selector": "div[class~=\"navForward\"]",
- "post_navigate_javascript_to_execute": "(function() { var elem = document.createElement('meta');elem.name='viewport';elem.content='initial-scale=1';document.body.appendChild(elem); })();",
- "wait_seconds": 2
+ "navigate_steps" : [
+ { "action": "navigate"},
+ { "action": "javascript", "expression": "(function() { var elem = document.createElement('meta');elem.name='viewport';elem.content='initial-scale=1';document.body.appendChild(elem); })();"},
+ { "action": "wait", "condition": "duration", "seconds": 2},
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]"}
+ ]
},
{
"url": "http://www.youtube.com",
"why": "#3 (Alexa global)",
- "wait_seconds": 2,
+ "navigate_steps" : [
+ { "action": "navigate"},
+ { "action": "wait", "condition": "duration", "seconds": 2}
+ ],
"credentials": "google"
},
{
@@ -35,7 +47,10 @@
"url": "http://www.facebook.com/barackobama",
"why": "top social,Public profile",
"credentials": "facebook",
- "wait_for_element_with_text": "About"
+ "navigate_steps" : [
+ { "action": "navigate"},
+ { "action": "wait", "condition": "element", "text": "About"}
+ ]
},
{
"name": "Wikipedia (1 tab)",

Powered by Google App Engine
This is Rietveld 408576698