content/test/gpu/gpu_tests/webgl_robustness.py - Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_tests/webgl_robustness.py

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/gpu/gpu_tests/webgl_conformance.py ('k') | content/test/gpu/page_sets/pixel_tests.json » ('j') | content/test/gpu/page_sets/pixel_tests.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/gpu/gpu_tests/webgl_robustness.py

diff --git a/content/test/gpu/gpu_tests/webgl_robustness.py b/content/test/gpu/gpu_tests/webgl_robustness.py

index 507d770b9d880d5a83d5cc189e1d0c43bd09de51..d45f563a411b34cd535ac62a9d33b89a0f81e6d0 100644

--- a/content/test/gpu/gpu_tests/webgl_robustness.py

+++ b/content/test/gpu/gpu_tests/webgl_robustness.py

@@ -57,7 +57,14 @@ class WebglRobustness(test.Test):

{

'url': 'file:///extra/lots-of-polys-example.html',

'script_to_evaluate_on_commit': robustness_harness_script,

- 'wait_for_javascript_expression': 'webglTestHarness._finished'

+ 'navigate_steps': [

+ { 'action': 'navigate' },

+ {

+ 'action': 'wait',

+ 'condition': 'javascript',

+ 'javascript': 'webglTestHarness._finished'

+ }

+ ]

}

]

}