content/test/gpu/gpu_tests/webgl_conformance.py - Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance.py

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/gpu/gpu_tests/webgl_conformance.py

diff --git a/content/test/gpu/gpu_tests/webgl_conformance.py b/content/test/gpu/gpu_tests/webgl_conformance.py

index 234a244b07166aa59847ebfc6956f10b93f48ce0..edc5b180b6044e275d6a5ba6248f948536a52211 100644

--- a/content/test/gpu/gpu_tests/webgl_conformance.py

+++ b/content/test/gpu/gpu_tests/webgl_conformance.py

@@ -84,7 +84,14 @@ class WebglConformance(test_module.Test):

pages.append({

'url': 'file:///' + test,

'script_to_evaluate_on_commit': conformance_harness_script,

- 'wait_for_javascript_expression': 'webglTestHarness._finished'

+ 'navigate_steps': [

+ {'action': 'navigate'},

+ {

+ 'action': 'wait',

+ 'condition': 'javascript',

+ 'javascript': 'webglTestHarness._finished'

+ }

+ ]

})

return page_set.PageSet.FromDict(page_set_dict, conformance_path)

« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/webgl_robustness.py » ('j') | tools/telemetry/telemetry/page/page.py » ('J')