tools/telemetry/telemetry/page/actions/reload.py - Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/telemetry/page/actions/reload.py

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Putting default navigate_steps inside page_set rather than page Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 from telemetry.page import page as page_module	4

5 from telemetry.page.actions import page_action	5 from telemetry.page.actions import page_action

6	6

7 class ReloadAction(page_action.PageAction):	7 class ReloadAction(page_action.PageAction):

8 def __init__(self, attributes=None):	8 def __init__(self, attributes=None):

9 super(ReloadAction, self).__init__(attributes)	9 super(ReloadAction, self).__init__(attributes)

10	10

11 def RunAction(self, page, tab, previous_action):	11 def RunAction(self, page, tab, previous_action):

12 tab.ExecuteJavaScript('window.location.reload()')	12 tab.ExecuteJavaScript('window.location.reload()')

13 page_module.Page.WaitForPageToLoad(self, tab, 60)

14 tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()	13 tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()

OLD	NEW