Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: chromecast/BUILD.gn

Issue 2288283002: [Chromecast] Rename disable_display flag to is_cast_audio_only. (Closed)
Patch Set: Pick up missing callsites Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/BUILD.gn
diff --git a/chromecast/BUILD.gn b/chromecast/BUILD.gn
index 8e1c18e9b1ada95972901d72f36b892024d8a274..185b07431a966fb5d6961e7564a13bc22b0b2e94 100644
--- a/chromecast/BUILD.gn
+++ b/chromecast/BUILD.gn
@@ -93,7 +93,7 @@ cast_test_group("cast_tests") {
# Disable ProcessUtilTest.* (need to define OS_ANDROID)
# Disable StackContainer.BufferAlignment (don't support 16-byte alignment)
# Disable SystemMetrics2Test.GetSystemMemoryInfo (buffers>0 can't be guaranteed)
- if (disable_display) {
+ if (cast_audio_only) {
# Also disable TimeFormattingTest on audio-only builds, since we don't
# include the necessary info in icudtl.dat.
filters += [ "base_unittests --gtest_filter=-ProcessMetricsTest.GetNumberOfThreads:ProcessUtilTest.*:StackContainer.BufferAlignment:SystemMetrics2Test.GetSystemMemoryInfo:TimeFormattingTest.*" ]
@@ -144,7 +144,7 @@ cast_test_group("cast_tests") {
}
}
- if (!disable_display) {
+ if (!cast_audio_only) {
tests += [ "//gpu:gpu_unittests" ]
}
}
@@ -306,7 +306,7 @@ action("chromecast_locales_pak") {
buildflag_header("chromecast_features") {
header = "chromecast_features.h"
- flags = [ "DISABLE_DISPLAY=$disable_display" ]
+ flags = [ "CAST_AUDIO_ONLY=$cast_audio_only" ]
}
if (is_android) {

Powered by Google App Engine
This is Rietveld 408576698