Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chromecast/BUILD.gn

Issue 2288283002: [Chromecast] Rename disable_display flag to is_cast_audio_only. (Closed)
Patch Set: cast_audio_only => is_cast_audio_only Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/chromecast_build.gni ('k') | chromecast/browser/cast_browser_main_parts.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/locales.gni") 7 import("//build/config/locales.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//chromecast/build/tests/cast_test.gni") 9 import("//chromecast/build/tests/cast_test.gni")
10 import("//chromecast/chromecast.gni") 10 import("//chromecast/chromecast.gni")
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 "media_unittests --gtest_filter=-AudioOutputControllerTest.PlayDivertSwitc hDeviceRevertClose:AudioOutputControllerTest.PlaySwitchDeviceClose:AudioStreamHa ndlerTest.Play:AudioStreamHandlerTest.ConsecutivePlayRequests:PipelineIntegratio nTest.BasicPlayback_MediaSource_VP9_WebM:PipelineIntegrationTest.BasicPlayback_V ideoOnly_VP9_WebM:PipelineIntegrationTest.BasicPlayback_VP9*:PipelineIntegration Test.P444_VP9_WebM:PipelineIntegrationTest.BasicPlayback_VP8A*:OpusAudioDecoderT est/AudioDecoderTest.ProduceAudioSamples/0:SoundsManagerTest.Play", 86 "media_unittests --gtest_filter=-AudioOutputControllerTest.PlayDivertSwitc hDeviceRevertClose:AudioOutputControllerTest.PlaySwitchDeviceClose:AudioStreamHa ndlerTest.Play:AudioStreamHandlerTest.ConsecutivePlayRequests:PipelineIntegratio nTest.BasicPlayback_MediaSource_VP9_WebM:PipelineIntegrationTest.BasicPlayback_V ideoOnly_VP9_WebM:PipelineIntegrationTest.BasicPlayback_VP9*:PipelineIntegration Test.P444_VP9_WebM:PipelineIntegrationTest.BasicPlayback_VP8A*:OpusAudioDecoderT est/AudioDecoderTest.ProduceAudioSamples/0:SoundsManagerTest.Play",
87 87
88 # DoAppendUTF8Invalid fails because of dcheck_always_on flag in Eng builds 88 # DoAppendUTF8Invalid fails because of dcheck_always_on flag in Eng builds
89 "url_unittests --gtest_filter=-URLCanonTest.DoAppendUTF8Invalid", 89 "url_unittests --gtest_filter=-URLCanonTest.DoAppendUTF8Invalid",
90 ] 90 ]
91 91
92 # Disable ProcessMetricsTest.GetNumberOfThreads (b/15610509) 92 # Disable ProcessMetricsTest.GetNumberOfThreads (b/15610509)
93 # Disable ProcessUtilTest.* (need to define OS_ANDROID) 93 # Disable ProcessUtilTest.* (need to define OS_ANDROID)
94 # Disable StackContainer.BufferAlignment (don't support 16-byte alignment) 94 # Disable StackContainer.BufferAlignment (don't support 16-byte alignment)
95 # Disable SystemMetrics2Test.GetSystemMemoryInfo (buffers>0 can't be guarant eed) 95 # Disable SystemMetrics2Test.GetSystemMemoryInfo (buffers>0 can't be guarant eed)
96 if (disable_display) { 96 if (is_cast_audio_only) {
97 # Also disable TimeFormattingTest on audio-only builds, since we don't 97 # Also disable TimeFormattingTest on audio-only builds, since we don't
98 # include the necessary info in icudtl.dat. 98 # include the necessary info in icudtl.dat.
99 filters += [ "base_unittests --gtest_filter=-ProcessMetricsTest.GetNumberO fThreads:ProcessUtilTest.*:StackContainer.BufferAlignment:SystemMetrics2Test.Get SystemMemoryInfo:TimeFormattingTest.*" ] 99 filters += [ "base_unittests --gtest_filter=-ProcessMetricsTest.GetNumberO fThreads:ProcessUtilTest.*:StackContainer.BufferAlignment:SystemMetrics2Test.Get SystemMemoryInfo:TimeFormattingTest.*" ]
100 } else { 100 } else {
101 filters += [ "base_unittests --gtest_filter=-ProcessMetricsTest.GetNumberO fThreads:ProcessUtilTest.*:StackContainer.BufferAlignment:SystemMetrics2Test.Get SystemMemoryInfo" ] 101 filters += [ "base_unittests --gtest_filter=-ProcessMetricsTest.GetNumberO fThreads:ProcessUtilTest.*:StackContainer.BufferAlignment:SystemMetrics2Test.Get SystemMemoryInfo" ]
102 } 102 }
103 } else if (is_cast_desktop_build || target_os == "android") { 103 } else if (is_cast_desktop_build || target_os == "android") {
104 filters += [ 104 filters += [
105 # URLRequestTestHTTP.GetTest_ManyCookies takes roughly 55s to run. Increas e 105 # URLRequestTestHTTP.GetTest_ManyCookies takes roughly 55s to run. Increas e
106 # timeout to 90s from 45s to allow it to pass (b/19821476) (b/29415636). 106 # timeout to 90s from 45s to allow it to pass (b/19821476) (b/29415636).
(...skipping 30 matching lines...) Expand all
137 "cast_shell_browser_test --no-sandbox --enable-local-file-accesses --enabl e-cma-media-pipeline --ozone-platform=cast --test-launcher-jobs=1" + use_gpu_swi tch, 137 "cast_shell_browser_test --no-sandbox --enable-local-file-accesses --enabl e-cma-media-pipeline --ozone-platform=cast --test-launcher-jobs=1" + use_gpu_swi tch,
138 "cast_media_unittests --test-launcher-jobs=1", 138 "cast_media_unittests --test-launcher-jobs=1",
139 "ipc_tests --test-launcher-jobs=1", 139 "ipc_tests --test-launcher-jobs=1",
140 ] 140 ]
141 141
142 if (use_alsa) { 142 if (use_alsa) {
143 tests += [ "//chromecast/media/cma/backend/alsa:cast_alsa_cma_backend_unit tests" ] 143 tests += [ "//chromecast/media/cma/backend/alsa:cast_alsa_cma_backend_unit tests" ]
144 } 144 }
145 } 145 }
146 146
147 if (!disable_display) { 147 if (!is_cast_audio_only) {
148 tests += [ "//gpu:gpu_unittests" ] 148 tests += [ "//gpu:gpu_unittests" ]
149 } 149 }
150 } 150 }
151 151
152 # Creates the build and run lists for all test targets. 152 # Creates the build and run lists for all test targets.
153 cast_test_group_list("cast_test_lists") { 153 cast_test_group_list("cast_test_lists") {
154 build_list_path = "$root_out_dir/tests/build_test_list.txt" 154 build_list_path = "$root_out_dir/tests/build_test_list.txt"
155 155
156 run_list_path = "$root_out_dir/tests/run_test_list.txt" 156 run_list_path = "$root_out_dir/tests/run_test_list.txt"
157 157
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 "$chromecast_branding", 299 "$chromecast_branding",
300 "-g", 300 "-g",
301 rebase_path("$root_gen_dir/chromecast_strings"), 301 rebase_path("$root_gen_dir/chromecast_strings"),
302 "-x", 302 "-x",
303 rebase_path("$root_out_dir/chromecast_locales"), 303 rebase_path("$root_out_dir/chromecast_locales"),
304 ] + locales 304 ] + locales
305 } 305 }
306 306
307 buildflag_header("chromecast_features") { 307 buildflag_header("chromecast_features") {
308 header = "chromecast_features.h" 308 header = "chromecast_features.h"
309 flags = [ "DISABLE_DISPLAY=$disable_display" ] 309 flags = [ "IS_CAST_AUDIO_ONLY=$is_cast_audio_only" ]
310 } 310 }
311 311
312 if (is_android) { 312 if (is_android) {
313 # GYP target: chromecast.gyp:cast_shell_icudata 313 # GYP target: chromecast.gyp:cast_shell_icudata
314 android_assets("cast_shell_apk_assets") { 314 android_assets("cast_shell_apk_assets") {
315 assert(v8_use_external_startup_data) 315 assert(v8_use_external_startup_data)
316 316
317 sources = [ 317 sources = [
318 "$root_out_dir/assets/cast_shell.pak", 318 "$root_out_dir/assets/cast_shell.pak",
319 ] 319 ]
(...skipping 11 matching lines...) Expand all
331 apk_name = "CastShell" 331 apk_name = "CastShell"
332 android_manifest = "$root_gen_dir/cast_shell_manifest/AndroidManifest.xml" 332 android_manifest = "$root_gen_dir/cast_shell_manifest/AndroidManifest.xml"
333 android_manifest_dep = "//chromecast/browser/android:cast_shell_manifest" 333 android_manifest_dep = "//chromecast/browser/android:cast_shell_manifest"
334 deps = [ 334 deps = [
335 ":cast_shell_apk_assets", 335 ":cast_shell_apk_assets",
336 "//chromecast/android:libcast_shell_android", 336 "//chromecast/android:libcast_shell_android",
337 "//chromecast/browser/android:cast_shell_java", 337 "//chromecast/browser/android:cast_shell_java",
338 ] 338 ]
339 } 339 }
340 } 340 }
OLDNEW
« no previous file with comments | « build/config/chromecast_build.gni ('k') | chromecast/browser/cast_browser_main_parts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698