Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2288273003:
Reland: Move DIP scale away from AwContents (Closed)
|
Created:
4 years, 3 months ago by Tima Vaisburd Modified:
4 years, 3 months ago CC:
chromium-reviews, android-webview-reviews_chromium.org, Jinsuk Kim Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland: Move DIP scale away from AwContents
This small refactoring removes device scale factor from AwContents
cache and uses the value from ContentViewCore.
The device scale factor in ContentViewCore is defined after
ContentViewCore native initialization, therefore this CL also
moves the device scale propagation until after that.
This is a prerequisite for https://codereview.chromium.org/2300463002
BUG=620929
> Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97
> Cr-Commit-Position: refs/heads/master@{#415546}
Reland after fix related to PopupTouchHandleDrawable.
Committed: https://crrev.com/bffd0a001eca22ac472bbc0ca8c942b73dfbcff2
Cr-Commit-Position: refs/heads/master@{#415690}
Patch Set 1 #Patch Set 2 : Rebase only #Patch Set 3 : Reland with a fix #Messages
Total messages: 28 (15 generated)
Description was changed from ========== Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequizite for ... BUG=632461 ========== to ========== Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequizite for https://codereview.chromium.org/2300463002 BUG=632461 ==========
timav@chromium.org changed reviewers: + boliu@chromium.org, sievers@chromium.org
PTAL.
lgtm > This is a prerequizite for https://codereview.chromium.org/2300463002 spelling
Description was changed from ========== Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequizite for https://codereview.chromium.org/2300463002 BUG=632461 ========== to ========== Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=632461 ==========
The CQ bit was checked by timav@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org Link to the patchset: https://codereview.chromium.org/2288273003/#ps20001 (title: "Rebase only")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=632461 ========== to ========== Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=632461 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=632461 ========== to ========== Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=632461 Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 Cr-Commit-Position: refs/heads/master@{#415546} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 Cr-Commit-Position: refs/heads/master@{#415546}
Message was sent while issue was closed.
FYI: Findit try jobs (rerunning failed compile or tests) identified this CL at revision 415546 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2297603004/ by tkent@chromium.org. The reason for reverting is: Android build failure. https://build.chromium.org/p/chromium/builders/Android/builds/61497/steps/com....
Message was sent while issue was closed.
yay midair collisions
Message was sent while issue was closed.
Description was changed from ========== Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=632461 Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 Cr-Commit-Position: refs/heads/master@{#415546} ========== to ========== Reland: Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=632461 > Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 > Cr-Commit-Position: refs/heads/master@{#415546} Reland after fix related to PopupTouchHandleDrawable. ==========
The CQ bit was checked by timav@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org Link to the patchset: https://codereview.chromium.org/2288273003/#ps40001 (title: "Reland with a fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
cc: +jinsukkim@
The CQ bit was unchecked by timav@chromium.org
Description was changed from ========== Reland: Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=632461 > Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 > Cr-Commit-Position: refs/heads/master@{#415546} Reland after fix related to PopupTouchHandleDrawable. ========== to ========== Reland: Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=620929 > Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 > Cr-Commit-Position: refs/heads/master@{#415546} Reland after fix related to PopupTouchHandleDrawable. ==========
The CQ bit was checked by timav@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Reland: Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=620929 > Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 > Cr-Commit-Position: refs/heads/master@{#415546} Reland after fix related to PopupTouchHandleDrawable. ========== to ========== Reland: Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=620929 > Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 > Cr-Commit-Position: refs/heads/master@{#415546} Reland after fix related to PopupTouchHandleDrawable. ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Reland: Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=620929 > Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 > Cr-Commit-Position: refs/heads/master@{#415546} Reland after fix related to PopupTouchHandleDrawable. ========== to ========== Reland: Move DIP scale away from AwContents This small refactoring removes device scale factor from AwContents cache and uses the value from ContentViewCore. The device scale factor in ContentViewCore is defined after ContentViewCore native initialization, therefore this CL also moves the device scale propagation until after that. This is a prerequisite for https://codereview.chromium.org/2300463002 BUG=620929 > Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97 > Cr-Commit-Position: refs/heads/master@{#415546} Reland after fix related to PopupTouchHandleDrawable. Committed: https://crrev.com/bffd0a001eca22ac472bbc0ca8c942b73dfbcff2 Cr-Commit-Position: refs/heads/master@{#415690} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/bffd0a001eca22ac472bbc0ca8c942b73dfbcff2 Cr-Commit-Position: refs/heads/master@{#415690} |
