Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2288253002: Roll GN (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Roll GN This picks up https://chromium.googlesource.com/chromium/src/tools/gn/+/efc976e5029419fde92111ce52f913c61fb9553c, which means we don't need to create a link_pool any more. The default behavior is unlimited linking, what we were asking for explicitly. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288253002 Committed: https://skia.googlesource.com/skia/+/a28e263d42760370c9ff0b269b31a78d6701fb44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gn/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mtklein_C
4 years, 3 months ago (2016-08-29 13:50:12 UTC) #6
jcgregorio
lgtm
4 years, 3 months ago (2016-08-29 13:51:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288253002/1
4 years, 3 months ago (2016-08-29 13:52:24 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 14:14:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a28e263d42760370c9ff0b269b31a78d6701fb44

Powered by Google App Engine
This is Rietveld 408576698