Remove FP16 support from ANGLE. Previous workaround was incomplete.

Remove FP16 support from ANGLE. Previous workaround was incomplete.

ANGLE is using the wrong external type (GL_HALF_FLOAT) when querying for
ReadPixels format, but it validates parameters to TexImage2D against the
correct type (GL_HALF_FLOAT_OES). Rather than introduce a lot of
complexity to work around the inconsistency, I'm just going to remove
support for now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288233002

Committed: https://skia.googlesource.com/skia/+/aa92afbf2002b8ddb51125adccd2625014234373

[Brian Osman, 2016-08-29 13:09:19]

Description was changed from

==========
Remove FP16 support from ANGLE. Previous workaround was incomplete.

ANGLE is using the wrong external type (GL_HALF_FLOAT) when querying for
ReadPixels format, but it validates parameters to TexImage2D against the
correct type (GL_HALF_FLOAT_OES). Rather than introduce a lot of
complexity to work around the inconsistency, I'm just going to remove
support for now.

BUG=skia:
==========

to

==========
Remove FP16 support from ANGLE. Previous workaround was incomplete.

ANGLE is using the wrong external type (GL_HALF_FLOAT) when querying for
ReadPixels format, but it validates parameters to TexImage2D against the
correct type (GL_HALF_FLOAT_OES). Rather than introduce a lot of
complexity to work around the inconsistency, I'm just going to remove
support for now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288233002
==========

[Brian Osman, 2016-08-29 13:12:54]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 13:13:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-08-29 13:14:26]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[bsalomon, 2016-08-29 13:15:07]

lgtm

[robertphillips, 2016-08-29 13:16:44]

lgtm

[Brian Osman, 2016-08-29 13:17:53]

The CQ bit was unchecked by brianosman@google.com

[Brian Osman, 2016-08-29 13:17:53]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-08-29 13:18:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 13:46:09]

Description was changed from

==========
Remove FP16 support from ANGLE. Previous workaround was incomplete.

ANGLE is using the wrong external type (GL_HALF_FLOAT) when querying for
ReadPixels format, but it validates parameters to TexImage2D against the
correct type (GL_HALF_FLOAT_OES). Rather than introduce a lot of
complexity to work around the inconsistency, I'm just going to remove
support for now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288233002
==========

to

==========
Remove FP16 support from ANGLE. Previous workaround was incomplete.

ANGLE is using the wrong external type (GL_HALF_FLOAT) when querying for
ReadPixels format, but it validates parameters to TexImage2D against the
correct type (GL_HALF_FLOAT_OES). Rather than introduce a lot of
complexity to work around the inconsistency, I'm just going to remove
support for now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288233002

Committed:
https://skia.googlesource.com/skia/+/aa92afbf2002b8ddb51125adccd2625014234373
==========

[commit-bot: I haz the power, 2016-08-29 13:46:11]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/aa92afbf2002b8ddb51125adccd2625014234373