Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Unified Diff: net/base/mime_util.cc

Issue 228823003: Adding check for MIME types that do not take codecs parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changing AreSupportedCodecs Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/renderer_webkitplatformsupport_impl.cc ('k') | net/base/mime_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/mime_util.cc
diff --git a/net/base/mime_util.cc b/net/base/mime_util.cc
index 4679dcc02e06e94a52641e6f388088eec5f9f313..fdb16fd8f7ef0b0f22b2d2e232198587ce19344d 100644
--- a/net/base/mime_util.cc
+++ b/net/base/mime_util.cc
@@ -438,7 +438,10 @@ static const MediaFormatStrict format_codec_mappings[] = {
{ "audio/x-wav", "1" },
{ "video/ogg", "opus,theora,vorbis" },
{ "audio/ogg", "opus,vorbis" },
- { "application/ogg", "opus,theora,vorbis" }
+ { "application/ogg", "opus,theora,vorbis" },
+ { "audio/mpeg", "" },
+ { "audio/mp3", "" },
+ { "audio/x-mp3", "" }
};
MimeUtil::MimeUtil() {
@@ -448,6 +451,9 @@ MimeUtil::MimeUtil() {
// static
bool MimeUtil::AreSupportedCodecs(const MimeMappings& supported_codecs,
const std::vector<std::string>& codecs) {
+ if (supported_codecs.empty())
+ return codecs.empty();
+
for (size_t i = 0; i < codecs.size(); ++i) {
if (supported_codecs.find(codecs[i]) == supported_codecs.end())
return false;
« no previous file with comments | « content/renderer/renderer_webkitplatformsupport_impl.cc ('k') | net/base/mime_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698