Adding check for MIME types that do not take codecs parameter

net/base/mime_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "net/base/mime_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 87 matching lines @@
   EXPECT_TRUE(IsStrictMediaMimeType("video/webm"));
   EXPECT_TRUE(IsStrictMediaMimeType("audio/webm"));
 
   EXPECT_TRUE(IsStrictMediaMimeType("audio/wav"));
   EXPECT_TRUE(IsStrictMediaMimeType("audio/x-wav"));
 
   EXPECT_TRUE(IsStrictMediaMimeType("video/ogg"));
   EXPECT_TRUE(IsStrictMediaMimeType("audio/ogg"));
   EXPECT_TRUE(IsStrictMediaMimeType("application/ogg"));
 
-  // TODO(amogh.bihani): These formats should be in stict-format_map_. This will
-  // be fixed with bug 53193 (http://crbug.com/53193)---------------------------
   EXPECT_FALSE(IsStrictMediaMimeType("audio/mpeg"));
   EXPECT_FALSE(IsStrictMediaMimeType("audio/mp3"));
   EXPECT_FALSE(IsStrictMediaMimeType("audio/x-mp3"));
 
+  // TODO(amogh.bihani): These formats should be in stict_format_map_. This will
+  // be fixed with bug 53193 (http://crbug.com/53193)---------------------------

[scherkus (not reviewing), 2014/04/10 18:30:11]

nit: you can just say "This will be fixed in http://crbug.com/53193" -- no need
to duplicate yourself :)

[amogh.bihani, 2014/04/11 05:24:07]

Done.

   EXPECT_FALSE(IsStrictMediaMimeType("video/mp4"));
-  EXPECT_FALSE(IsStrictMediaMimeType("video/x-mp4v"));
+  EXPECT_FALSE(IsStrictMediaMimeType("video/x-m4v"));
   EXPECT_FALSE(IsStrictMediaMimeType("audio/mp4"));
-  EXPECT_FALSE(IsStrictMediaMimeType("audio/x-mp4a"));
+  EXPECT_FALSE(IsStrictMediaMimeType("audio/x-m4a"));

[Ryan Sleevi, 2014/04/10 19:04:16]

Seems like an unrelated change?

[amogh.bihani, 2014/04/11 05:24:07]

Yes it is an unrelated change. This test was added in my last CL[1] for fixing
*/ogg and audio/x-wav false positive results.
I made a typo there. Since the expectation is false, the test passed and I did
not notice it. I thought I should correct it here itself. Or should I create
another CL for this?
-------
[1] https://codereview.chromium.org/218303002/

 
   EXPECT_FALSE(IsStrictMediaMimeType("application/x-mpegurl"));
   EXPECT_FALSE(IsStrictMediaMimeType("application/vnd.apple.mpegurl"));
   // ---------------------------------------------------------------------------
 
   EXPECT_FALSE(IsStrictMediaMimeType("video/unknown"));
   EXPECT_FALSE(IsStrictMediaMimeType("audio/unknown"));
   EXPECT_FALSE(IsStrictMediaMimeType("application/unknown"));
   EXPECT_FALSE(IsStrictMediaMimeType("unknown/unknown"));
 }
 
+TEST(MimeUtilTest, MimeTypeDoesNotNeedCodecs) {
+  EXPECT_TRUE(MimeTypeDoesNotNeedCodecs("audio/mpeg"));
+  EXPECT_TRUE(MimeTypeDoesNotNeedCodecs("audio/mp3"));
+  EXPECT_TRUE(MimeTypeDoesNotNeedCodecs("audio/x-mp3"));
+
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("audio/webm"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("video/webm"));
+
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("audio/wav"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("audio/x-wav"));
+
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("audio/ogg"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("video/ogg"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("application/ogg"));
+
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("audio/mp4"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("video/mp4"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("audio/x-m4a"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("video/x-m4v"));
+
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("application/x-mpegurl"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("application/vnd.apple.mpegurl"));
+
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("video/unknown"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("audio/unknown"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("application/unknown"));
+  EXPECT_FALSE(MimeTypeDoesNotNeedCodecs("unknown/unknown"));
+}
+
 TEST(MimeUtilTest, MatchesMimeType) {
   EXPECT_TRUE(MatchesMimeType("*", "video/x-mpeg"));
   EXPECT_TRUE(MatchesMimeType("video/*", "video/x-mpeg"));
   EXPECT_TRUE(MatchesMimeType("video/*", "video/*"));
   EXPECT_TRUE(MatchesMimeType("video/x-mpeg", "video/x-mpeg"));
   EXPECT_TRUE(MatchesMimeType("application/*+xml",
                                    "application/html+xml"));
   EXPECT_TRUE(MatchesMimeType("application/*+xml", "application/+xml"));
   EXPECT_TRUE(MatchesMimeType("application/*+json",
                                    "application/x-myformat+json"));
@@ skipping 214 matching lines @@
   std::string post_data;
   AddMultipartValueForUpload("value name", "value", "boundary",
                              "content type", &post_data);
   AddMultipartValueForUpload("value name", "value", "boundary",
                              "", &post_data);
   AddMultipartFinalDelimiterForUpload("boundary", &post_data);
   EXPECT_STREQ(ref_output, post_data.c_str());
 }
 
 }  // namespace net