Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/analyzer/tool/task_dependency_graph/tasks.dot

Issue 2288223003: Don't perform final fields and top-level variables type propagation. (Closed)
Patch Set: Rewrite 'reuse' tests using 'inferredTypeSlot'. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/task/dart_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/tool/task_dependency_graph/tasks.dot
diff --git a/pkg/analyzer/tool/task_dependency_graph/tasks.dot b/pkg/analyzer/tool/task_dependency_graph/tasks.dot
index 7cf3d9d7bd8dcc7d0d2363fcdf8efc008da673a7..e6af22908f3ab228fff7f43d6bc867c2790d96b4 100644
--- a/pkg/analyzer/tool/task_dependency_graph/tasks.dot
+++ b/pkg/analyzer/tool/task_dependency_graph/tasks.dot
@@ -48,24 +48,23 @@ digraph G {
CREATED_RESOLVED_UNIT [shape=box]
CREATED_RESOLVED_UNIT1 [shape=box]
CREATED_RESOLVED_UNIT10 -> InferInstanceMembersInUnitTask
+ CREATED_RESOLVED_UNIT10 -> InferStaticVariableTypeTask
+ CREATED_RESOLVED_UNIT10 -> PartiallyResolveUnitReferencesTask
+ CREATED_RESOLVED_UNIT10 -> ResolveInstanceFieldsInUnitTask
+ CREATED_RESOLVED_UNIT10 -> ResolveUnitTask
CREATED_RESOLVED_UNIT10 [shape=box]
- CREATED_RESOLVED_UNIT11 -> InferInstanceMembersInUnitTask
- CREATED_RESOLVED_UNIT11 -> InferStaticVariableTypeTask
- CREATED_RESOLVED_UNIT11 -> PartiallyResolveUnitReferencesTask
- CREATED_RESOLVED_UNIT11 -> ResolveInstanceFieldsInUnitTask
- CREATED_RESOLVED_UNIT11 -> ResolveUnitTask
+ CREATED_RESOLVED_UNIT11 -> ResolveConstantExpressionTask
CREATED_RESOLVED_UNIT11 [shape=box]
- CREATED_RESOLVED_UNIT12 -> ResolveConstantExpressionTask
CREATED_RESOLVED_UNIT12 [shape=box]
- CREATED_RESOLVED_UNIT13 [shape=box]
CREATED_RESOLVED_UNIT2 [shape=box]
CREATED_RESOLVED_UNIT3 [shape=box]
CREATED_RESOLVED_UNIT4 [shape=box]
CREATED_RESOLVED_UNIT5 [shape=box]
CREATED_RESOLVED_UNIT6 [shape=box]
CREATED_RESOLVED_UNIT7 [shape=box]
+ CREATED_RESOLVED_UNIT8 -> ResolveInstanceFieldsInUnitTask
CREATED_RESOLVED_UNIT8 [shape=box]
- CREATED_RESOLVED_UNIT9 -> ResolveInstanceFieldsInUnitTask
+ CREATED_RESOLVED_UNIT9 -> InferInstanceMembersInUnitTask
CREATED_RESOLVED_UNIT9 [shape=box]
ComputeConstantDependenciesTask -> CONSTANT_DEPENDENCIES
ComputeConstantValueTask -> CONSTANT_VALUE
@@ -73,7 +72,6 @@ digraph G {
ComputeLibraryCycleTask -> LIBRARY_CYCLE
ComputeLibraryCycleTask -> LIBRARY_CYCLE_DEPENDENCIES
ComputeLibraryCycleTask -> LIBRARY_CYCLE_UNITS
- ComputePropagableVariableDependenciesTask -> PROPAGABLE_VARIABLE_DEPENDENCIES
ComputeRequiredConstantsTask -> PENDING_ERRORS
ComputeRequiredConstantsTask -> REQUIRED_CONSTANTS
ContainingLibrariesTask -> CONTAINING_LIBRARIES
@@ -86,14 +84,14 @@ digraph G {
EXPORTED_LIBRARIES -> BuildDirectiveElementsTask
EXPORTED_LIBRARIES -> ReadyLibraryElement2Task
EXPORTED_LIBRARIES -> ReadyLibraryElement5Task
- EXPORTED_LIBRARIES -> ReadyLibraryElement6Task
+ EXPORTED_LIBRARIES -> ReadyLibraryElement7Task
EXPORTED_LIBRARIES -> ResolveTopLevelLibraryTypeBoundsTask
EXPORTED_LIBRARIES [shape=box]
EXPORT_SOURCE_CLOSURE -> BuildExportNamespaceTask
EXPORT_SOURCE_CLOSURE -> ResolveTopLevelUnitTypeBoundsTask
EXPORT_SOURCE_CLOSURE [shape=box]
- EvaluateUnitConstantsTask -> CREATED_RESOLVED_UNIT13
- EvaluateUnitConstantsTask -> RESOLVED_UNIT13
+ EvaluateUnitConstantsTask -> CREATED_RESOLVED_UNIT12
+ EvaluateUnitConstantsTask -> RESOLVED_UNIT12
GatherUsedImportedElementsTask -> USED_IMPORTED_ELEMENTS
GatherUsedLocalElementsTask -> USED_LOCAL_ELEMENTS
GenerateHintsTask -> HINTS
@@ -105,7 +103,7 @@ digraph G {
IMPORTED_LIBRARIES -> BuildDirectiveElementsTask
IMPORTED_LIBRARIES -> ReadyLibraryElement2Task
IMPORTED_LIBRARIES -> ReadyLibraryElement5Task
- IMPORTED_LIBRARIES -> ReadyLibraryElement6Task
+ IMPORTED_LIBRARIES -> ReadyLibraryElement7Task
IMPORTED_LIBRARIES -> ResolveTopLevelLibraryTypeBoundsTask
IMPORTED_LIBRARIES -> ResolveTopLevelUnitTypeBoundsTask
IMPORTED_LIBRARIES [shape=box]
@@ -119,12 +117,12 @@ digraph G {
INFERRED_STATIC_VARIABLE -> InferStaticVariableTypesInUnitTask
INFERRED_STATIC_VARIABLE [shape=box]
IS_LAUNCHABLE [shape=box]
- InferInstanceMembersInUnitTask -> CREATED_RESOLVED_UNIT11
- InferInstanceMembersInUnitTask -> RESOLVED_UNIT11
+ InferInstanceMembersInUnitTask -> CREATED_RESOLVED_UNIT10
+ InferInstanceMembersInUnitTask -> RESOLVED_UNIT10
InferStaticVariableTypeTask -> INFERRED_STATIC_VARIABLE
InferStaticVariableTypeTask -> STATIC_VARIABLE_RESOLUTION_ERRORS
- InferStaticVariableTypesInUnitTask -> CREATED_RESOLVED_UNIT9
- InferStaticVariableTypesInUnitTask -> RESOLVED_UNIT9
+ InferStaticVariableTypesInUnitTask -> CREATED_RESOLVED_UNIT8
+ InferStaticVariableTypesInUnitTask -> RESOLVED_UNIT8
InferStaticVariableTypesInUnitTask -> STATIC_VARIABLE_RESOLUTION_ERRORS_IN_UNIT
LIBRARY_CYCLE [shape=box]
LIBRARY_CYCLE_DEPENDENCIES -> InferInstanceMembersInUnitTask
@@ -158,12 +156,12 @@ digraph G {
LIBRARY_ELEMENT5 -> ResolveUnitTypeNamesTask
LIBRARY_ELEMENT5 [shape=box]
LIBRARY_ELEMENT6 -> PartiallyResolveUnitReferencesTask
- LIBRARY_ELEMENT6 -> PropagateVariableTypesInLibraryTask
LIBRARY_ELEMENT6 -> ReadyLibraryElement5Task
LIBRARY_ELEMENT6 -> ResolveInstanceFieldsInUnitTask
+ LIBRARY_ELEMENT6 -> ResolvedUnit7InLibraryTask
LIBRARY_ELEMENT6 [shape=box]
- LIBRARY_ELEMENT7 -> PropagateVariableTypesInLibraryClosureTask
- LIBRARY_ELEMENT7 -> ReadyLibraryElement6Task
+ LIBRARY_ELEMENT7 -> ReadyLibraryElement7Task
+ LIBRARY_ELEMENT7 -> ResolvedUnit7InLibraryClosureTask
LIBRARY_ELEMENT7 [shape=box]
LIBRARY_ELEMENT8 -> ResolveLibraryReferencesTask
LIBRARY_ELEMENT8 -> ResolveUnitTask
@@ -173,11 +171,11 @@ digraph G {
LIBRARY_ELEMENT9 [shape=box]
LIBRARY_ERRORS_READY [shape=box]
LIBRARY_SPECIFIC_UNITS -> GenerateHintsTask
- LIBRARY_SPECIFIC_UNITS -> PropagateVariableTypesInLibraryTask
LIBRARY_SPECIFIC_UNITS -> ReadyResolvedUnitTask
LIBRARY_SPECIFIC_UNITS -> ResolveLibraryReferencesTask
LIBRARY_SPECIFIC_UNITS -> ResolveLibraryTypeNamesTask
LIBRARY_SPECIFIC_UNITS -> ResolveTopLevelLibraryTypeBoundsTask
+ LIBRARY_SPECIFIC_UNITS -> ResolvedUnit7InLibraryTask
LIBRARY_SPECIFIC_UNITS [shape=box]
LIBRARY_UNIT_ERRORS -> dartErrorsForUnit
LIBRARY_UNIT_ERRORS [shape=box]
@@ -200,13 +198,6 @@ digraph G {
PARSE_ERRORS [shape=box]
PENDING_ERRORS -> VerifyUnitTask
PENDING_ERRORS [shape=box]
- PROPAGABLE_VARIABLES_IN_UNIT -> PropagateVariableTypesInUnitTask
- PROPAGABLE_VARIABLES_IN_UNIT [shape=box]
- PROPAGABLE_VARIABLE_DEPENDENCIES -> PropagateVariableTypeTask
- PROPAGABLE_VARIABLE_DEPENDENCIES [shape=box]
- PROPAGATED_VARIABLE -> PropagateVariableTypeTask
- PROPAGATED_VARIABLE -> PropagateVariableTypesInUnitTask
- PROPAGATED_VARIABLE [shape=box]
ParseDartTask -> EXPLICITLY_IMPORTED_LIBRARIES
ParseDartTask -> EXPORTED_LIBRARIES
ParseDartTask -> IMPORTED_LIBRARIES
@@ -220,21 +211,15 @@ digraph G {
ParseDartTask -> UNITS
PartiallyResolveUnitReferencesTask -> CREATED_RESOLVED_UNIT7
PartiallyResolveUnitReferencesTask -> INFERABLE_STATIC_VARIABLES_IN_UNIT
- PartiallyResolveUnitReferencesTask -> PROPAGABLE_VARIABLES_IN_UNIT
PartiallyResolveUnitReferencesTask -> RESOLVED_UNIT7
- PropagateVariableTypeTask -> PROPAGATED_VARIABLE
- PropagateVariableTypesInLibraryClosureTask -> LIBRARY_ELEMENT8
- PropagateVariableTypesInLibraryTask -> LIBRARY_ELEMENT7
- PropagateVariableTypesInUnitTask -> CREATED_RESOLVED_UNIT8
- PropagateVariableTypesInUnitTask -> RESOLVED_UNIT8
READY_LIBRARY_ELEMENT2 -> ComputeLibraryCycleTask
READY_LIBRARY_ELEMENT2 -> ReadyLibraryElement2Task
READY_LIBRARY_ELEMENT2 [shape=box]
READY_LIBRARY_ELEMENT6 -> PartiallyResolveUnitReferencesTask
READY_LIBRARY_ELEMENT6 -> ReadyLibraryElement5Task
READY_LIBRARY_ELEMENT6 [shape=box]
- READY_LIBRARY_ELEMENT7 -> PropagateVariableTypesInLibraryClosureTask
- READY_LIBRARY_ELEMENT7 -> ReadyLibraryElement6Task
+ READY_LIBRARY_ELEMENT7 -> ReadyLibraryElement7Task
+ READY_LIBRARY_ELEMENT7 -> ResolvedUnit7InLibraryClosureTask
READY_LIBRARY_ELEMENT7 [shape=box]
READY_RESOLVED_UNIT -> ResolveLibraryTask
READY_RESOLVED_UNIT -> VerifyUnitTask
@@ -255,17 +240,15 @@ digraph G {
RESOLVED_UNIT1 -> BuildLibraryElementTask
RESOLVED_UNIT1 -> ResolveDirectiveElementsTask
RESOLVED_UNIT1 [shape=box]
- RESOLVED_UNIT10 -> InferInstanceMembersInUnitTask
+ RESOLVED_UNIT10 -> ResolveUnitTask
RESOLVED_UNIT10 [shape=box]
- RESOLVED_UNIT11 -> ResolveUnitTask
+ RESOLVED_UNIT11 -> EvaluateUnitConstantsTask
+ RESOLVED_UNIT11 -> GatherUsedImportedElementsTask
+ RESOLVED_UNIT11 -> GatherUsedLocalElementsTask
+ RESOLVED_UNIT11 -> ResolveLibraryReferencesTask
RESOLVED_UNIT11 [shape=box]
- RESOLVED_UNIT12 -> EvaluateUnitConstantsTask
- RESOLVED_UNIT12 -> GatherUsedImportedElementsTask
- RESOLVED_UNIT12 -> GatherUsedLocalElementsTask
- RESOLVED_UNIT12 -> ResolveLibraryReferencesTask
+ RESOLVED_UNIT12 -> StrongModeVerifyUnitTask
RESOLVED_UNIT12 [shape=box]
- RESOLVED_UNIT13 -> StrongModeVerifyUnitTask
- RESOLVED_UNIT13 [shape=box]
RESOLVED_UNIT2 -> BuildEnumMemberElementsTask
RESOLVED_UNIT2 [shape=box]
RESOLVED_UNIT3 -> ResolveTopLevelUnitTypeBoundsTask
@@ -279,15 +262,13 @@ digraph G {
RESOLVED_UNIT6 -> PartiallyResolveUnitReferencesTask
RESOLVED_UNIT6 [shape=box]
RESOLVED_UNIT7 -> ComputeInferableStaticVariableDependenciesTask
- RESOLVED_UNIT7 -> ComputePropagableVariableDependenciesTask
- RESOLVED_UNIT7 -> PropagateVariableTypeTask
- RESOLVED_UNIT7 -> PropagateVariableTypesInUnitTask
+ RESOLVED_UNIT7 -> InferStaticVariableTypeTask
+ RESOLVED_UNIT7 -> InferStaticVariableTypesInUnitTask
+ RESOLVED_UNIT7 -> ResolvedUnit7InLibraryTask
RESOLVED_UNIT7 [shape=box]
- RESOLVED_UNIT8 -> InferStaticVariableTypeTask
- RESOLVED_UNIT8 -> InferStaticVariableTypesInUnitTask
- RESOLVED_UNIT8 -> PropagateVariableTypesInLibraryTask
+ RESOLVED_UNIT8 -> ResolveInstanceFieldsInUnitTask
RESOLVED_UNIT8 [shape=box]
- RESOLVED_UNIT9 -> ResolveInstanceFieldsInUnitTask
+ RESOLVED_UNIT9 -> InferInstanceMembersInUnitTask
RESOLVED_UNIT9 [shape=box]
RESOLVE_TYPE_BOUNDS_ERRORS -> LibraryUnitErrorsTask
RESOLVE_TYPE_BOUNDS_ERRORS [shape=box]
@@ -297,13 +278,13 @@ digraph G {
RESOLVE_UNIT_ERRORS [shape=box]
ReadyLibraryElement2Task -> READY_LIBRARY_ELEMENT2
ReadyLibraryElement5Task -> READY_LIBRARY_ELEMENT6
- ReadyLibraryElement6Task -> READY_LIBRARY_ELEMENT7
+ ReadyLibraryElement7Task -> READY_LIBRARY_ELEMENT7
ReadyResolvedUnitTask -> READY_RESOLVED_UNIT
ResolveConstantExpressionTask -> CONSTANT_EXPRESSION_RESOLVED
ResolveDirectiveElementsTask -> CREATED_RESOLVED_UNIT2
ResolveDirectiveElementsTask -> RESOLVED_UNIT2
- ResolveInstanceFieldsInUnitTask -> CREATED_RESOLVED_UNIT10
- ResolveInstanceFieldsInUnitTask -> RESOLVED_UNIT10
+ ResolveInstanceFieldsInUnitTask -> CREATED_RESOLVED_UNIT9
+ ResolveInstanceFieldsInUnitTask -> RESOLVED_UNIT9
ResolveLibraryReferencesTask -> LIBRARY_ELEMENT9
ResolveLibraryTask -> LIBRARY_ELEMENT
ResolveLibraryTypeNamesTask -> LIBRARY_ELEMENT6
@@ -312,8 +293,8 @@ digraph G {
ResolveTopLevelUnitTypeBoundsTask -> RESOLVED_UNIT4
ResolveTopLevelUnitTypeBoundsTask -> RESOLVE_TYPE_BOUNDS_ERRORS
ResolveUnitTask -> CONSTANT_EXPRESSIONS_DEPENDENCIES
- ResolveUnitTask -> CREATED_RESOLVED_UNIT12
- ResolveUnitTask -> RESOLVED_UNIT12
+ ResolveUnitTask -> CREATED_RESOLVED_UNIT11
+ ResolveUnitTask -> RESOLVED_UNIT11
ResolveUnitTask -> RESOLVE_UNIT_ERRORS
ResolveUnitTypeNamesTask -> CREATED_RESOLVED_UNIT5
ResolveUnitTypeNamesTask -> RESOLVED_UNIT5
@@ -321,6 +302,8 @@ digraph G {
ResolveVariableReferencesTask -> CREATED_RESOLVED_UNIT6
ResolveVariableReferencesTask -> RESOLVED_UNIT6
ResolveVariableReferencesTask -> VARIABLE_REFERENCE_ERRORS
+ ResolvedUnit7InLibraryClosureTask -> LIBRARY_ELEMENT8
+ ResolvedUnit7InLibraryTask -> LIBRARY_ELEMENT7
SCAN_ERRORS -> dartErrorsForSource
SCAN_ERRORS [shape=box]
SOURCE_KIND -> BuildDirectiveElementsTask
@@ -347,7 +330,6 @@ digraph G {
TYPE_PROVIDER -> InferInstanceMembersInUnitTask
TYPE_PROVIDER -> InferStaticVariableTypeTask
TYPE_PROVIDER -> PartiallyResolveUnitReferencesTask
- TYPE_PROVIDER -> PropagateVariableTypeTask
TYPE_PROVIDER -> ResolveInstanceFieldsInUnitTask
TYPE_PROVIDER -> ResolveLibraryTypeNamesTask
TYPE_PROVIDER -> ResolveTopLevelUnitTypeBoundsTask
« no previous file with comments | « pkg/analyzer/test/src/task/dart_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698