pkg/analyzer/lib/src/plugin/engine_plugin.dart - Issue 2288223003: Don't perform final fields and top-level variables type propagation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/plugin/engine_plugin.dart

Issue 2288223003: Don't perform final fields and top-level variables type propagation. (Closed)

Patch Set: Rewrite 'reuse' tests using 'inferredTypeSlot'. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/plugin/engine_plugin.dart

diff --git a/pkg/analyzer/lib/src/plugin/engine_plugin.dart b/pkg/analyzer/lib/src/plugin/engine_plugin.dart

index 8e477079c700c12918aa2de87b3c0b2766300c16..ecf2e360eb7f63eaee8d07eea5d35a973ad4a055 100644

--- a/pkg/analyzer/lib/src/plugin/engine_plugin.dart

+++ b/pkg/analyzer/lib/src/plugin/engine_plugin.dart

@@ -205,8 +205,6 @@ class EnginePlugin implements Plugin {

taskId, ComputeInferableStaticVariableDependenciesTask.DESCRIPTOR);

registerExtension(taskId, ComputeLibraryCycleTask.DESCRIPTOR);

registerExtension(taskId, ComputeRequiredConstantsTask.DESCRIPTOR);

- registerExtension(

- taskId, ComputePropagableVariableDependenciesTask.DESCRIPTOR);

registerExtension(taskId, ContainingLibrariesTask.DESCRIPTOR);

registerExtension(taskId, DartErrorsTask.DESCRIPTOR);

registerExtension(taskId, EvaluateUnitConstantsTask.DESCRIPTOR);

@@ -221,17 +219,14 @@ class EnginePlugin implements Plugin {

registerExtension(taskId, LibraryUnitErrorsTask.DESCRIPTOR);

registerExtension(taskId, ParseDartTask.DESCRIPTOR);

registerExtension(taskId, PartiallyResolveUnitReferencesTask.DESCRIPTOR);

- registerExtension(

- taskId, PropagateVariableTypesInLibraryClosureTask.DESCRIPTOR);

- registerExtension(taskId, PropagateVariableTypesInLibraryTask.DESCRIPTOR);

- registerExtension(taskId, PropagateVariableTypesInUnitTask.DESCRIPTOR);

- registerExtension(taskId, PropagateVariableTypeTask.DESCRIPTOR);

registerExtension(taskId, ReadyLibraryElement2Task.DESCRIPTOR);

registerExtension(taskId, ReadyLibraryElement5Task.DESCRIPTOR);

- registerExtension(taskId, ReadyLibraryElement6Task.DESCRIPTOR);

+ registerExtension(taskId, ReadyLibraryElement7Task.DESCRIPTOR);

registerExtension(taskId, ReadyResolvedUnitTask.DESCRIPTOR);

registerExtension(taskId, ResolveConstantExpressionTask.DESCRIPTOR);

registerExtension(taskId, ResolveDirectiveElementsTask.DESCRIPTOR);

+ registerExtension(taskId, ResolvedUnit7InLibraryClosureTask.DESCRIPTOR);

+ registerExtension(taskId, ResolvedUnit7InLibraryTask.DESCRIPTOR);

registerExtension(taskId, ResolveInstanceFieldsInUnitTask.DESCRIPTOR);

registerExtension(taskId, ResolveLibraryReferencesTask.DESCRIPTOR);

registerExtension(taskId, ResolveLibraryTask.DESCRIPTOR);