Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: pkg/analysis_server/test/completion_test.dart

Issue 2288223003: Don't perform final fields and top-level variables type propagation. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/completion_test.dart
diff --git a/pkg/analysis_server/test/completion_test.dart b/pkg/analysis_server/test/completion_test.dart
index de88533b2720b0cb234a4b6e266436e826bd9fde..70ac85438ea320116b1c5b05e926239111a2926b 100644
--- a/pkg/analysis_server/test/completion_test.dart
+++ b/pkg/analysis_server/test/completion_test.dart
@@ -2850,7 +2850,7 @@ class A {
// test analysis of untyped fields and top-level vars
buildTests('test035', '''class Y {final x='hi';mth() {x.!1length;}}''',
- <String>["1+length"]);
+ <String>["1+length"], failingTests: '1');
Brian Wilkerson 2016/08/29 20:49:03 It seems odd to have a single test that is expecte
Paul Berry 2016/08/29 20:53:35 As a counterpoint to that, this is a test that we
scheglov 2016/08/29 20:53:55 I thought we might want to keep it to re-enable wh
Brian Wilkerson 2016/08/29 21:13:24 Why not just set strong mode for this one test? (I
// TODO(scheglov) decide what to do with Type for untyped field (not
// supported by the new store)

Powered by Google App Engine
This is Rietveld 408576698